Page MenuHomeFreeBSD
Differential D14792

Flag pending TUR.
ClosedPublic
Actions

Authored by imp on Mar 22 2018, 5:36 AM.
Tags
None
Referenced Files
F135931862: D14792.diff
Fri, Nov 14, 7:02 AM
Unknown Object (File)
Thu, Nov 13, 7:54 AM
Unknown Object (File)
Mon, Nov 10, 12:56 AM
Unknown Object (File)
Sat, Nov 8, 2:00 AM
Unknown Object (File)
Sat, Oct 25, 7:00 AM
Unknown Object (File)
Sat, Oct 25, 7:00 AM
Unknown Object (File)
Sat, Oct 25, 7:00 AM
Unknown Object (File)
Sat, Oct 25, 12:44 AM
View All Files
Subscribers
hyun_caffeinated.codes

Details

Reviewers
imp
Group Reviewers
cam
Summary

Flag when we have a pending TUR. Don't schedule another one when we
have one pending. Otherwise, we can race and send two, which is
wasteful in close proximity. It can also cause the acaquire/release
count for TUR to be > 1, which is undexpected.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15709
Build 15735: arc lint + arc unit

Event Timeline

imp created this revision.Mar 22 2018, 5:36 AM
Harbormaster completed remote builds in B15709: Diff 40585.Mar 22 2018, 5:36 AM
imp updated this revision to Diff 40586.Mar 22 2018, 5:46 AM

Spell sc right <doh>!

Harbormaster completed remote builds in B15710: Diff 40586.Mar 22 2018, 5:46 AM
hyun_caffeinated.codes added a subscriber: hyun_caffeinated.codes.Mar 26 2018, 11:53 PM

I have tried this diff on r331284 and it still panic when I plug my Transcend microSD reader in. The stack backtrace is exactly same with what I've supplied in the mailing list.

imp accepted this revision.Jul 10 2021, 3:57 PM
This revision is now accepted and ready to land.Jul 10 2021, 3:57 PM
Herald added a reviewer: cam. · View Herald TranscriptJul 10 2021, 3:57 PM
imp closed this revision.Jul 10 2021, 3:57 PM

landed as 6a6c0d584479f / r331435

Revision Contents
Changeset List

PathSize
sys/
cam/
scsi/
11 lines

Diff 40585

View Options

sys/cam/scsi/scsi_da.c

Loading...