Stagify russian/ircd-hybrid
ClosedPublic
Actions

Authored by rodrigo on Jun 13 2014, 9:25 AM.

Details

Reviewers

bapt
kwm

Summary

stagify the port
fix clang issues
fix plist issues

Approved by: xxx (mentor)

Test Plan

Last poudriere log
http://www.bebik.net/poudriere/10amd64-svn-commit-tree/2014-06-13_11h12m19s/logs/ru-ircd-hybrid-7.2.4.log

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rodrigo updated this revision to Diff 390.Jun 13 2014, 9:25 AM

rodrigo retitled this revision from to Stagify russian/ircd-hybrid.

rodrigo updated this object.

rodrigo edited the test plan for this revision. (Show Details)

rodrigo added reviewers: bapt, kwm.

This will fail with pkg_install you should add @exec install -d -m 755 -o %%USR%% -g %%GRP%% /var/log/ircd-hybrid-ru (until pkg_install support dies)

With your code etc/ircd-hybrid-ru/codepages etc/ircd-hybrid-ru will be owned by %%USR%%/%%GRP is that intended?

last to rest properly ownership you must use @owner root @group wheel not just @owner with no arguments

List Item

This revision now requires changes to proceed.Jun 13 2014, 9:31 AM

Fix plist as suggested
You're right etc/ircd-hybrid-ru/codepages etc/ircd-hybrid-ru must be owned by root
Fix default ownership (porters handbook section 7.6.7.5 & 7.6.7.6 must be fixed, right ?)

<quote>
@owner : Set default ownership for all subsequent files to user. Use without an argument to set back to default ownership (root).
@group: Set default group ownership for all subsequent files to group. Use without an arg to set back to default group ownership (wheel).
</quote>

http://www.bebik.net/poudriere/10amd64-svn-commit-tree/2014-06-13_11h53m15s/logs/ru-ircd-hybrid-7.2.4.log