Page MenuHomeFreeBSD
Differential D13555

devel/awscli: use USE_PTYHON=noflavors, remove PKGNAMEPREFIX
ClosedPublic
Actions

Authored by bhughes on Dec 20 2017, 1:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 23, 2:47 PM
Unknown Object (File)
Sun, Jan 5, 5:35 PM
Unknown Object (File)
Dec 12 2024, 10:10 PM
Unknown Object (File)
Dec 8 2024, 6:00 AM
Unknown Object (File)
Dec 5 2024, 4:58 PM
Unknown Object (File)
Nov 28 2024, 5:16 PM
Unknown Object (File)
Nov 26 2024, 2:10 AM
Unknown Object (File)
Nov 26 2024, 2:10 AM
View All Files
Subscribers
None

Details

Reviewers
robak
mat
Commits
rP460348: MFH: r457853
rP457853: devel/awscli: use USE_PTYHON=noflavors, remove PKGNAMEPREFIX
Summary

devel/awscli: use USE_PTYHON=noflavors, remove PKGNAMEPREFIX

The introduction of flavors caused the awscli package to be renamed to
py27-awscli. Since this package is preinstalled on all AWS EC2 instances
running a FreeBSD image, apply POLA and rename the package back to
awscli. The assumption is that the rename was unintentional.

Approved by: robak (mentor)
MFH: 2018Q1

Test Plan

$ pwd
/usr/ports/devel/awscli
$ portlint -C
WARN: Makefile: no port directory /usr/ports/devel/py-botocore@py27 found, even though it is listed in RUN_DEPENDS.
WARN: Makefile: no port directory /usr/ports/devel/py-colorama@py27 found, even though it is listed in RUN_DEPENDS.
WARN: Makefile: no port directory /usr/ports/net/py-s3transfer@py27 found, even though it is listed in RUN_DEPENDS.
WARN: Makefile: no port directory /usr/ports/textproc/py-docutils@py27 found, even though it is listed in RUN_DEPENDS.
WARN: Makefile: no port directory /usr/ports/security/py-rsa@py27 found, even though it is listed in RUN_DEPENDS.
WARN: Makefile: no port directory /usr/ports/devel/py-yaml@py27 found, even though it is listed in RUN_DEPENDS.
0 fatal errors and 6 warnings found.

http://35.176.221.15/data/latest-per-pkg/awscli/1.14.13/

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 13717
Build 13937: arc lint + arc unit

Event Timeline

bhughes created this revision.Dec 20 2017, 1:16 PM
robak added a comment.Dec 20 2017, 1:24 PM

Wouldn't we want an UPDATING entry explaining the situation?

bhughes added a comment.Dec 20 2017, 2:03 PM
In D13555#283531, @robak wrote:

Wouldn't we want an UPDATING entry explaining the situation?

Yes, that's a good idea. I will add one and update the diff.

bhughes updated this revision to Diff 36852.Dec 21 2017, 8:55 AM

Change to use USE_PYTHON=noflavors instead of optsuffix, added UPDATING entry

Harbormaster completed remote builds in B13711: Diff 36852.Dec 21 2017, 8:55 AM
bhughes retitled this revision from devel/awscli: use USE_PTYHON=optsuffix instead of PKGNAMEPREFIX to devel/awscli: use USE_PTYHON=noflavors, remove PKGNAMEPREFIX.Dec 21 2017, 8:58 AM
bhughes edited the summary of this revision. (Show Details)
bhughes updated this revision to Diff 36853.Dec 21 2017, 9:02 AM

Refined the UPDATING entry more

bhughes updated this revision to Diff 36855.Dec 21 2017, 9:05 AM

Finishing touches on UPDATING

mat added inline comments.Dec 21 2017, 11:32 AM
UPDATING
15
s/PY_FLAVOR/Python's default version/

Or even better, simply remove the last sentence.

bhughes marked an inline comment as done.Dec 21 2017, 12:39 PM
bhughes added inline comments.
UPDATING
15

Indeed. I removed the last sentence. :)

bhughes updated this revision to Diff 36859.Dec 21 2017, 12:40 PM
bhughes marked an inline comment as done.

Remove last sentence from UPDATING entry, as suggested by mat@

Harbormaster completed remote builds in B13717: Diff 36859.Dec 21 2017, 12:40 PM
bhughes added a comment.Dec 21 2017, 12:40 PM

Thanks :)

bhughes updated this revision to Diff 37068.Dec 26 2017, 8:25 PM

Resolving UPDATING conflicts

bhughes updated this revision to Diff 37371.Jan 1 2018, 8:42 PM

Resolved UPDATING conflicts

Harbormaster completed remote builds in B14040: Diff 37371.Jan 1 2018, 8:42 PM
bhughes edited the summary of this revision. (Show Details)Jan 1 2018, 8:58 PM
mat accepted this revision.Jan 2 2018, 1:19 PM
This revision is now accepted and ready to land.Jan 2 2018, 1:19 PM
Closed by commit rP457853: devel/awscli: use USE_PTYHON=noflavors, remove PKGNAMEPREFIX (authored by bhughes). · Explain WhyJan 2 2018, 1:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
8 lines
devel/
awscli/
15 lines

Diff 36859

View Options

UPDATING

Loading...
View Options

devel/awscli/Makefile

Loading...