Page MenuHomeFreeBSD

astro/gpstk: drop unused dependencies
ClosedPublic

Authored by jbeich on Oct 7 2017, 4:45 PM.
Tags
None
Referenced Files
F171286044: D12617.diff
Thu, Sep 10, 3:47 AM
Unknown Object (File)
Wed, Sep 9, 1:09 PM
Unknown Object (File)
Wed, Sep 9, 9:21 AM
Unknown Object (File)
Tue, Sep 8, 2:06 PM
Unknown Object (File)
Sun, Aug 30, 11:38 AM
Unknown Object (File)
Sat, Aug 22, 10:45 AM
Unknown Object (File)
Sat, Aug 15, 8:45 AM
Unknown Object (File)
Aug 8 2026, 6:01 PM
Subscribers
None

Details

Summary

rP370634 added USE_GCC without documenting rationale. gpstk-2.5 built fine by Clang and no consumers required libgpstk.so to be linked against libstdc++.so.

Kurt, why did you add the dependency then? To fix a runtime issue? I don't use the port, so have no clue, and there's no maintainer to ask.

Test Plan

Builds fine on

$ pkg info -ql gpstk | xargs fgrep python
/usr/local/include/TabularSatStore.hpp:   // typedefs had to be set to public for python bindings to compile

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 11944
Build 12272: arc lint + arc unit

Event Timeline

That was a long time ago, it probably did not build at that time without USE_GCC. If it builds now, remove USE_GCC, that's fine with me.

This revision is now accepted and ready to land.Oct 7 2017, 5:30 PM
This revision was automatically updated to reflect the committed changes.