- Update MASTER_SITES - Add RUN_DEPENDS - Set dependencies according to Makefile.PL - Sort _DEPENDS - Update WWW and fix syntax in pkg-descr - Bump PORTREVISION
Details
- Reviewers
sunpoet - Commits
- rP446015: MFH: r446000
rP446000: - Update MASTER_SITES
- portlint -ac output looks fine.
- poudriere testport build logs are fine.
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
I provide the make test output
====> Running Q/A tests (stage-qa) Notice: You have some Perl modules as dependencies but you do not have devel/p5-Module-CoreList installed, the perlcore QA check gets better results when using it, especially with older Perl versions. ===> Testing for p5-LaTeXML-0.8.2 ===> p5-LaTeXML-0.8.2 depends on package: p5-File-Which>=0 - found @ test = `"/usr/local/bin/perl5.24.1" -ne 'chomp;if(s/.*?REVISION\s*=\s*\"// && s/\".*//){print;}' < blib/lib/LaTeXML/Version.pm` || "/usr/local/bin/perl5.24.1" -pe "s@__REVISION__@@" lib/LaTeXML/Version.in > blib/lib/LaTeXML/Version.pm /bin/sh: @: not found PERL_DL_NONLAZY=1 "/usr/local/bin/perl5.24.1" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/00_tokenize.t ........ ok t/10_expansion.t ....... 6/? # Skip: Missing requirement ifthen.sty for t/expansion/ifthen t/10_expansion.t ....... 11/? # Skip: Missing requirement t1enc.def for t/expansion/meaning t/10_expansion.t ....... ok t/12_grouping.t ........ ok t/20_digestion.t ....... ok t/22_fonts.t ........... ok t/30_encoding.t ........ 1/? # Skip: Missing requirement ansinew.def for t/encoding/ansinew # Skip: Missing requirement applemac.def for t/encoding/applemac # Skip: Missing requirement cp1250.def for t/encoding/cp1250 # Skip: Missing requirement cp1252.def for t/encoding/cp1252 # Skip: Missing requirement cp437.def for t/encoding/cp437 # Skip: Missing requirement cp437de.def for t/encoding/cp437de # Skip: Missing requirement cp850.def for t/encoding/cp850 # Skip: Missing requirement cp852.def for t/encoding/cp852 # Skip: Missing requirement cp858.def for t/encoding/cp858 # Skip: Missing requirement cp865.def for t/encoding/cp865 # Skip: Missing requirement decmulti.def for t/encoding/decmulti # Skip: Missing requirement latin1.def for t/encoding/latin1 # Skip: Missing requirement latin10.def for t/encoding/latin10 # Skip: Missing requirement latin2.def for t/encoding/latin2 t/30_encoding.t ........ 15/? # Skip: Missing requirement latin3.def for t/encoding/latin3 # Skip: Missing requirement latin4.def for t/encoding/latin4 # Skip: Missing requirement latin5.def for t/encoding/latin5 # Skip: Missing requirement latin9.def for t/encoding/latin9 # Skip: Missing requirement ly1enc.def for t/encoding/ly1 # Skip: Missing requirement ot1enc.def for t/encoding/ot1 # Skip: Missing requirement t1enc.def for t/encoding/t1 # Skip: Missing requirement t2aenc.def for t/encoding/t2a # Skip: Missing requirement t2benc.def for t/encoding/t2b # Skip: Missing requirement t2cenc.def for t/encoding/t2c # Skip: Missing requirement ts1enc.def for t/encoding/ts1 t/30_encoding.t ........ ok t/40_math.t ............ ok t/50_structure.t ....... ok t/52_namespace.t ....... ok t/53_alignment.t ....... 7/? # Skip: Missing requirement listings.cfg for t/alignment/listing t/53_alignment.t ....... ok t/55_theorem.t ......... 3/? # Skip: Missing requirement ntheorem.std for t/theorem/ntheorem t/55_theorem.t ......... ok t/56_ams.t ............. ok t/65_graphics.t ........ 2/? # Skip: Missing requirement dvipsnam.def for t/graphics/colors t/65_graphics.t ........ 7/? # Skip: Missing requirement dvipsnam.def for t/graphics/xcolors t/65_graphics.t ........ ok t/70_parse.t ........... ok t/80_complex.t ......... ok t/81_babel.t ........... 1/? # Skip: Missing requirement babel.sty for t/babel/ t/81_babel.t ........... ok t/90_latexmlpost.t ..... ok t/91_latexmlc_api.t .... ok t/92_profiles.t ........ 2/? # Skip: Missing requirement dvipsnam.def for t/daemon/profiles/fragment # Skip: Missing requirement dvipsnam.def for t/daemon/profiles/math t/92_profiles.t ........ ok t/93_formats.t ......... ok t/94_runtimes.t ........ ok t/95_complex_config.t .. ok All tests successful. Files=22, Tests=229, 124 wallclock secs ( 0.08 usr 0.10 sys + 82.38 cusr 31.21 csys = 113.77 CPU) Result: PASS
According to Makefile.PL, the dependency list of p5- ports is:
p5-Archive-Zip>=0:archivers/p5-Archive-Zip \ p5-File-Which>=0:sysutils/p5-File-Which \ p5-IO-String>=0:devel/p5-IO-String \ p5-Image-Size>=0:graphics/p5-Image-Size \ p5-JSON-XS>=0:converters/p5-JSON-XS \ p5-Parse-RecDescent>=0:devel/p5-Parse-RecDescent \ p5-URI>=0:net/p5-URI \ p5-XML-LibXML>=1.62:textproc/p5-XML-LibXML \ p5-XML-LibXSLT>=1.58:textproc/p5-XML-LibXSLT \ p5-libwww>=0:www/p5-libwww
Note that I remove the Perl core modules (DB_File, Getopt::Long, Text::Unidecode, Test::More, Time::HiRes and version).
One more thing, please bump PORTREVISION since it includes a runtime dependency change.
converters/p5-LaTeXML/Makefile | ||
---|---|---|
8 | I just noticed that it's not downloaded from CPAN. Since its CPAN page/link is available, would you like to change MASTER_SITES to CPAN or add CPAN as primary MASTER_SITES? | |
19–22 | It's not in alphabetic order. | |
28 | Could you recheck this? It seems not a test-only dependency. % grep -r File::Which * bin/latexmlc:use File::Which; lib/LaTeXML/Post/LaTeXImages.pm:use File::Which; lib/LaTeXML/Package.pm:use File::Which; lib/LaTeXML/Util/Test.pm:use File::Which; lib/LaTeXML/Util/Pathname.pm:use File::Which; |
converters/p5-LaTeXML/Makefile | ||
---|---|---|
8 | Forgot to say that I prefer CPAN because it has more mirrors. It helps to avoid potential download failure. |
- Update MASTER_SITES
- Move p5-File-Which to the appropriate place
- Update WWW in pkg-descr
converters/p5-LaTeXML/Makefile | ||
---|---|---|
19–22 | It's sorted by port origin. |
converters/p5-LaTeXML/Makefile | ||
---|---|---|
8 | I agree. |
LGTM. Thank you!
converters/p5-LaTeXML/Makefile | ||
---|---|---|
19–22 | Oh, I see. Personally, I would sort it by module name because it's easier to check with PREREQ_PM or so. |
converters/p5-LaTeXML/Makefile | ||
---|---|---|
19–22 | I have no problem in sorting the dependency list by the module name :) |