Differential D11451

Extend pr_allow flags to 64bit
ClosedPublic
Actions

Authored by netchild on Jul 2 2017, 6:03 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Dec 23 2023, 2:05 AM

	Unknown Object (File)
	Nov 29 2023, 4:17 AM

	Unknown Object (File)
	Jun 19 2023, 6:13 AM

	Unknown Object (File)
	Jan 6 2023, 3:26 AM

Subscribers

None

Details

Reviewers

Commits

rS320826: - Extend pr_allow flags visually to 32 bits, to make it more obvious at first…

Summary

Change pr_allow from 32bit to 64bit. I looked at some places in the two files
and it looks to me like all the places are already 64bit safe (or uses already 64bit).
I did not check other files for the use of the structure, but I have a kernel up and running
with this change. As a test I (re-)added the kmem_allow flag (which I would like to add without
the userland part (the revert of this last time was because of the user interface of the
uerland part, not about the feature itself), and this works.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

netchild created this revision.Jul 2 2017, 6:03 PM

It has only exhausted 16 bits, no? I would think if you added the flag but left pr_allow as plain "unsigned" your kernel would still work.

Keep it at 32bits, only extend the defines to cover visually 32bits instead of only 16 (and keep
the new flag).

Harbormaster completed remote builds in B10279: Diff 30374.Jul 3 2017, 8:48 PM

jamie accepted this revision.Jul 3 2017, 8:53 PM

This revision is now accepted and ready to land.Jul 3 2017, 8:53 PM

Closed by commit rS320826: - Extend pr_allow flags visually to 32 bits, to make it more obvious at first… (authored by netchild). · Explain WhyJul 9 2017, 6:40 AM

This revision was automatically updated to reflect the committed changes.

netchild mentioned this in rS320826: - Extend pr_allow flags visually to 32 bits, to make it more obvious at first….

Revision Contents
Changeset List

Path

Size

head/

sys/

sys/

35 lines

Diff 30597

head/sys/sys/jail.h

Loading...