Fix build, unbreak after x11-toolkits/scintilla update
ClosedPublic
Actions

Authored by krion on Mar 12 2017, 10:14 AM.

Details

Reviewers

mat

Commits

rP436103: - Fix build

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217697

Add new necessary dependencies
Replace portions of CPPFLAGS and LDFLAGS with sed patches for ${WRKSRC}/configure
Add sed patch to rename some deprecated structure names after v3.7.1 update of x11-toolkits/scintilla

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 8014
Build 8188: arc lint + arc unit

Event Timeline

krion created this revision.Mar 12 2017, 10:14 AM

Harbormaster completed remote builds in B8014: Diff 26181.Mar 12 2017, 10:14 AM

Looks good, but for the patches, we try to not commit metadata changes needlessly. So, changing the header, or the "c function" generate by -p is not a reason to update patches.

On the other hand, changing the line numbers in the hunk first line (the @@ -xxx,xx +xxx,xx @@ bit) would warrant an update. (It is not the case here.)

This revision is now accepted and ready to land.Mar 13 2017, 4:44 PM

Closed by commit rP436103: - Fix build (authored by krion). · Explain WhyMar 13 2017, 6:17 PM

This revision was automatically updated to reflect the committed changes.