Details
- Reviewers
fjoe mat - Commits
- rP433557: - Update sysutils/backuppc to 3.3.2
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Paths
| Differential D9472 Authored by krion on Feb 7 2017, 11:36 AM.
Details
Summary
Diff Detail
Event Timelinekrion updated this object.
This revision is now accepted and ready to land.Feb 7 2017, 2:34 PM2017-02-07 14:34:31 (UTC+0) Closed by commit rP433557: - Update sysutils/backuppc to 3.3.2 (authored by krion). · Explain WhyFeb 7 2017, 2:40 PM2017-02-07 14:40:03 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 24835 head/sysutils/backuppc/Makefile
head/sysutils/backuppc/distinfo
head/sysutils/backuppc/files/patch-doc-BackupPC.pod
head/sysutils/backuppc/files/patch-lib_BackupPC_CGI_Browse.pm
|
Any specific reason to write the or statement as two separate if clauses?
I believe in other parts we do it ((true & x & y & z) | (false & a & b &c )) - as multiline checks;
I don't like them both get executed "always", so at the very least, an "else" just before the 2nd if would be good.
The logic looks ok to me.