Page MenuHomeFreeBSD
Differential D8283

Optimize COPYTREE_*
ClosedPublic
Actions

Authored by mat on Oct 19 2016, 1:57 PM.
Tags
None
Referenced Files
F105916945: D8283.diff
Sun, Dec 22, 3:24 PM
Unknown Object (File)
Nov 16 2024, 1:18 PM
Unknown Object (File)
Nov 3 2024, 3:36 AM
Unknown Object (File)
Nov 2 2024, 7:41 AM
Unknown Object (File)
Oct 18 2024, 2:03 PM
Unknown Object (File)
Oct 14 2024, 10:30 AM
Unknown Object (File)
Oct 6 2024, 8:34 AM
Unknown Object (File)
Oct 3 2024, 7:48 AM
View All 97 Files
Subscribers
None

Details

Reviewers
None
Group Reviewers
portmgr
Commits
rP425793: Optimize COPYTREE_* macros.
Summary

The current chmod commands can't use -exec + because they fiddle with the
pathnames. By switching directory beforehand, it makes it possible to chmod
more than one file at once.

Test Plan

small benchmark, for what it's worth www/sit installs 2k files with a home baked version

www/sit (2k)www/mathjax (30k)
home baked0.032u 0.104s 0:00.13 100.0% 127+236k 4+0io 0pf+0w0.946u 7.446s 0:08.34 100.4% 40+225k 18276+31io 45pf+0w
current0.281u 0.649s 0:00.92 100.0% 37+171k 4+0io 0pf+0w5.446u 18.626s 0:23.99 100.2% 29+171k 18289+31io 0pf+0w
new0.024u 0.081s 0:00.10 100.0% 177+214k 4+0io 0pf+0w0.770u 7.012s 0:07.80 99.7% 41+197k 15444+31io 45pf+0w

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 5652
Build 5933: arc lint + arc unit

Event Timeline

mat updated this revision to Diff 21496.Oct 19 2016, 1:57 PM
mat retitled this revision from to Optimize COPYTREE_*.
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat added a reviewer: portmgr.Oct 19 2016, 1:59 PM
mat updated this revision to Diff 21497.Oct 19 2016, 2:02 PM
  • Add a bit of a comment.
mat added a comment.Oct 19 2016, 2:27 PM
This comment was removed by mat.
mat updated this revision to Diff 21543.Oct 20 2016, 3:48 PM
  • Collapse two lines, make it more readable.
  • Use find -E

Three ports use -regex or -iregex with COPYTREE_*, I'm looking if they need fixing.
devel/ocaml-findlib devel/sdl12 databases/leo_center

mat added a comment.Oct 20 2016, 3:54 PM

Good, all three ports using it work just fine with find -E

mat updated this revision to Diff 21591.Oct 21 2016, 2:27 PM
  • Think about it and refactor with only one find for all the chmods.
mat edited the test plan for this revision. (Show Details)Oct 24 2016, 12:13 PM
Closed by commit rP425793: Optimize COPYTREE_* macros. (authored by mat). · Explain WhyNov 9 2016, 12:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
Mk/
8 lines

Diff 21496

View Options

Mk/bsd.port.mk

Loading...