lang/python314: Add DTRACE
Needs ReviewPublic
Actions

Authored by 0mp on Mon, Oct 5, 3:14 PM.

Details

Summary

We need to patch configure the same way NetBSD does it.
See https://github.com/python/cpython/pull/137444.

Option DTRACE is incompatible with option LTO due to build
failures:

dtrace: failed to link script ./Include/pydtrace.d: invalid file type: Python/ceval.o

That probably caused by the fact that, when LTO is enabled, the object
files during build contain LLVM bitcode instead of ELF objects.

PR: 288359
Sponsored by: fme AG

Test Plan

Test instructions:

Build the port with DTRACE enable and LTO disabled.
Install the port.
Run dtrace -l -n 'python*:::' -c 'python3.14 --version' | grep libpython to confirm the presence of DTrace probes.

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77721
Build 74604: arc lint + arc unit

0mp requested review of this revision.Mon, Oct 5, 3:14 PM

0mp created this revision.

0mp added subscribers: Python, smyru.

0mp edited the test plan for this revision. (Show Details)Mon, Oct 5, 3:18 PM

0mp edited the summary of this revision. (Show Details)Mon, Oct 5, 3:34 PM

As mentioned in D31489, the inability of LTO and DTrace to work together is unacceptable.

It looks like the build failure with both LTO and DTrace enabled was reported upstream some time ago.

lang/python314/Makefile
79	https://llvm.org/docs/FatLTO.html The one obvious downside is an increase in resulting package size. However, this allows enabling both LTO and DTRACE options, with a caveat:
80	In theory this should also be passed to the linker (lld), but LTO linking fails, so let the linker fall back to non-LTO linking. This flag is placed here instead of in LTO because the resulting package size balloons to 2-3×. Also when LTO is disabled, this flag is a no-op.
81	Please put this in `pkg-plist`.