Page MenuHomeFreeBSD

mail/postfix: Fix double slashes in pkg-install paths
AcceptedPublic

Authored by olgeni on Thu, Oct 1, 10:17 PM.
Tags
None
Referenced Files
F174419347: D60212.id188348.diff
Sat, Oct 3, 1:40 AM
F174417568: D60212.diff
Sat, Oct 3, 1:21 AM
Unknown Object (File)
Fri, Oct 2, 10:18 AM
Unknown Object (File)
Fri, Oct 2, 7:53 AM
Subscribers
None

Details

Reviewers
otis
Summary

pkg runs install scripts with PKG_ROOTDIR=/, so prepending it to
absolute paths printed "//usr/local/etc/mail/mailer.conf" in the
activation message. MC_BASE relied on the trailing slash instead and
would break with "pkg -r /some/root".

Strip the trailing slash once and always join with an explicit "/".

Also included as a separate commit: reorder ALL_TARGET and PORTSCOUT
to make portclippy happy (no functional change).

Test Plan

testport on 14.4-amd64: build, install/deinstall and check-plist
clean; the activation message now reads
"/usr/local/etc/mail/mailer.conf".

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 77588
Build 74471: arc lint + arc unit

Event Timeline

olgeni held this revision as a draft.
olgeni retitled this revision from mail/postfix: Fix Makefile variable order (portclippy) to mail/postfix: Fix double slashes in pkg-install paths.Thu, Oct 1, 10:18 PM
olgeni edited the summary of this revision. (Show Details)
olgeni edited the test plan for this revision. (Show Details)
olgeni published this revision for review.Thu, Oct 1, 10:37 PM

LGTM. Morevoer, PORTSCOUT should be updated to look for 3.11.x.

Could you also do this for postfix-current, please?

This revision is now accepted and ready to land.Fri, Oct 2, 4:21 PM