da: Update stats with the periph lock held
Needs ReviewPublic
Actions

Authored by imp on Tue, Sep 29, 10:14 PM.

Tags

None

Referenced Files

	F174167230: D60156.id188144.diff
	Thu, Oct 1, 2:21 AM

	F174161064: D60156.id188144.diff
	Thu, Oct 1, 1:03 AM

	F174154840: D60156.diff
	Wed, Sep 30, 11:51 PM

	F174074460: D60156.id188144.diff
	Wed, Sep 30, 10:24 AM

	F174073949: D60156.diff
	Wed, Sep 30, 10:19 AM

	Unknown Object (File)
	Wed, Sep 30, 4:36 AM

	Unknown Object (File)
	Wed, Sep 30, 1:04 AM

Subscribers

ali_mashtizadeh.com

Details

Reviewers

None

Group Reviewers

cam

Summary

We can race in updating the stats, so delay dropping the periph lock
until after we've updated them for trims.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77509
Build 74392: arc lint + arc unit

Event Timeline

imp created this revision.Tue, Sep 29, 10:14 PM

Herald added a reviewer: cam. · View Herald TranscriptTue, Sep 29, 10:14 PM

imp requested review of this revision.Tue, Sep 29, 10:14 PM

imp added a parent revision: D60155: nvme_da: drop periph lock after updating stats for trim.

Harbormaster completed remote builds in B77509: Diff 188144.Tue, Sep 29, 10:15 PM

imp added a child revision: D60157: ada: Call trim stats update for all bios.Tue, Sep 29, 10:15 PM

We aren't somehow double counting because of bp->bio_resid vs all the other bios we iterate over?

Revision Contents
Changeset List

Path

Size

sys/

cam/

scsi/

scsi_da.c

18 lines

Diff 188144

View Options

da: Update stats with the periph lock heldNeeds ReviewPublicActions