Differential D59558

ufshci: add a control device node
ClosedPublic
Actions

Authored by jaeyoon on Thu, Sep 10, 8:23 AM.

Tags

None

Referenced Files

	F174366517: D59558.diff
	Fri, Oct 2, 5:35 PM

	Unknown Object (File)
	Sun, Sep 27, 12:50 PM

	Unknown Object (File)
	Sat, Sep 26, 11:15 PM

	Unknown Object (File)
	Sat, Sep 26, 9:25 PM

	Unknown Object (File)
	Sat, Sep 26, 2:46 PM

	Unknown Object (File)
	Fri, Sep 25, 4:53 AM

	Unknown Object (File)
	Thu, Sep 24, 8:04 AM

	Unknown Object (File)
	Thu, Sep 24, 7:25 AM

View All 40 Files

Subscribers

None

Details

Reviewers

Commits

rG28fefc441e3b: ufshci: add a control device node

Summary

The driver only exposed a CAM SIM. Userland had no way to reach the
device for anything that is not a SCSI command, so reading a descriptor
or an attribute was impossible.

Add /dev/ufshci%d as a root only node and the ioctl ABI header for it.
The node answers no ioctl yet. The header pulls in ufshci.h, which
declares bool only under _KERNEL, so include stdbool.h for userland the
way nvme.h already does.

Sponsored by: Samsung Electronics

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jaeyoon requested review of this revision.Thu, Sep 10, 8:23 AM

jaeyoon created this revision.

Harbormaster completed remote builds in B76728: Diff 186340.Thu, Sep 10, 8:23 AM

jaeyoon added a parent revision: D59557: ufshci: tell the controller how long the EHS is.Thu, Sep 10, 8:23 AM

jaeyoon added a child revision: D59559: ufshci: add a passthrough ioctl.Thu, Sep 10, 8:28 AM

imp accepted this revision.Sat, Sep 12, 7:52 PM

This revision is now accepted and ready to land.Sat, Sep 12, 7:52 PM

Closed by commit rG28fefc441e3b: ufshci: add a control device node (authored by jaeyoon). · Explain WhyTue, Sep 15, 1:48 AM

This revision was automatically updated to reflect the committed changes.

jaeyoon added a commit: rG28fefc441e3b: ufshci: add a control device node.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ufshci/

3 lines

6 lines

54 lines

67 lines

ufshci_private.h

6 lines

modules/

ufshci/

1 line

Diff 186747

sys/dev/ufshci/ufshci.h

Loading...

sys/dev/ufshci/ufshci_ctrlr.c

Loading...

sys/dev/ufshci/ufshci_ioctl.h

Loading...

sys/dev/ufshci/ufshci_ioctl.c

Loading...

sys/dev/ufshci/ufshci_private.h

Loading...

sys/modules/ufshci/Makefile

Loading...