Page MenuHomeFreeBSD
Differential D58275

devel/sem: Declare libzstd shlib dependency
ClosedPublic
Actions

Authored by olgeni on Thu, Jul 16, 8:09 AM.
Tags
None
Referenced Files
F164670164: D58275.id182068.diff
Mon, Aug 3, 2:19 AM
Unknown Object (File)
Sun, Aug 2, 3:07 AM
Unknown Object (File)
Sat, Aug 1, 11:05 AM
Unknown Object (File)
Sat, Aug 1, 7:03 AM
Unknown Object (File)
Tue, Jul 28, 11:35 PM
Unknown Object (File)
Tue, Jul 28, 8:18 PM
Unknown Object (File)
Tue, Jul 28, 9:21 AM
Unknown Object (File)
Sat, Jul 25, 12:22 AM
View All 23 Files
Subscribers
None

Details

Reviewers
adamw
Commits
R11:8e5d1047bf23: devel/sem: Declare libzstd shlib dependency
Summary

The binary links libzstd.so.1 (via the zstd-sys crate, which uses
pkg-config to pick up the system libzstd by default), but the port
does not declare the runtime dependency.

Detected by poudriere stage-qa:

Warning: sem-0.21.0 will be rebuilt as it misses libzstd.so.1
which no dependency provides. It is likely (silently) failing
testport/stage-qa.

Add LIB_DEPENDS=libzstd.so:archivers/zstd and bump PORTREVISION.

Test Plan

poudriere testport on 15.1-amd64 - clean build, stage-qa no longer
reports the missing libzstd.so.1 shlib, package installs and
deinstalls cleanly.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 74845
Build 71728: arc lint + arc unit

Event Timeline

olgeni created this revision.Thu, Jul 16, 8:09 AM
olgeni held this revision as a draft.
Harbormaster completed remote builds in B74845: Diff 182068.Thu, Jul 16, 8:09 AM
olgeni published this revision for review.Thu, Jul 16, 8:17 AM
adamw accepted this revision.Sat, Jul 18, 4:23 AM

Great catch! Thank you, Jimmy!

This revision is now accepted and ready to land.Sat, Jul 18, 4:23 AM
Closed by commit R11:8e5d1047bf23: devel/sem: Declare libzstd shlib dependency (authored by olgeni). · Explain WhyMon, Jul 20, 1:38 AM
This revision was automatically updated to reflect the committed changes.
olgeni added a commit: R11:8e5d1047bf23: devel/sem: Declare libzstd shlib dependency.

Revision Contents
Changeset List

PathSize
devel/
sem/
4 lines

Diff 182068

View Options

devel/sem/Makefile

Loading...