aue(4): fix link flaps from MII bus
Needs ReviewPublic
Actions

Authored by rkitover_gmail.com on Jun 14 2026, 3:28 AM.

Tags

Referenced Files

	F171202549: D57567.id179706.diff
	Wed, Sep 9, 11:59 AM

	Unknown Object (File)
	Sun, Sep 6, 7:52 PM

	Unknown Object (File)
	Fri, Sep 4, 3:43 PM

	Unknown Object (File)
	Fri, Sep 4, 6:32 AM

	Unknown Object (File)
	Fri, Sep 4, 4:05 AM

	Unknown Object (File)
	Thu, Sep 3, 2:39 AM

	Unknown Object (File)
	Wed, Sep 2, 4:55 PM

	Unknown Object (File)
	Wed, Sep 2, 8:15 AM

View All 52 Files

Subscribers

imp

This revision needs review, but there are no reviewers specified.

Details

Reviewers: None

Summary

A race condition in the MII layer causes spurious events, see:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252165

. Add a lock to serialize operations on the MII bus and skip ticks while
it is held.

I have tested this patch with my Belkin USB 10/100 Ethernet Adapter
F5D5050.

Signed-off-by: Rafael Kitover <rkitover@gmail.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 73859
Build 70742: arc lint + arc unit

Event Timeline

rkitover_gmail.com created this revision.Jun 14 2026, 3:28 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 14 2026, 3:28 AM

rkitover_gmail.com requested review of this revision.Jun 14 2026, 3:28 AM

Harbormaster completed remote builds in B73859: Diff 179706.Jun 14 2026, 3:28 AM

Add Differential Review to commit message

Harbormaster completed remote builds in B73860: Diff 179707.Jun 14 2026, 3:30 AM

rkitover_gmail.com added projects: USB, desktop.Jun 14 2026, 3:31 AM

rkitover_gmail.com mentioned this in D57566: aue(4): fix incorrect media detection.Jun 14 2026, 3:36 AM

rkitover_gmail.com mentioned this in D55631: axge: fix spurious link down from MII, frozen TX.

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

net/

if_aue.c

25 lines

if_auereg.h

4 lines

Diff 179706

View Options

sys/dev/usb/net/if_aue.c