aue(4): fix link flaps from MII bus
Needs ReviewPublic
Actions

Authored by rkitover_gmail.com on Sun, Jun 14, 3:28 AM.

Tags

Referenced Files

	F160328193: D57567.id179706.diff
	Tue, Jun 23, 8:09 AM

	Unknown Object (File)
	Mon, Jun 22, 2:37 PM

	Unknown Object (File)
	Sun, Jun 21, 5:13 AM

	Unknown Object (File)
	Fri, Jun 19, 9:24 PM

	Unknown Object (File)
	Fri, Jun 19, 2:03 AM

	Unknown Object (File)
	Thu, Jun 18, 12:50 AM

	Unknown Object (File)
	Wed, Jun 17, 10:37 PM

	Unknown Object (File)
	Wed, Jun 17, 10:00 PM

View All 10 Files

Subscribers

imp

This revision needs review, but there are no reviewers specified.

Details

Reviewers: None

Summary

A race condition in the MII layer causes spurious events, see:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252165

. Add a lock to serialize operations on the MII bus and skip ticks while
it is held.

I have tested this patch with my Belkin USB 10/100 Ethernet Adapter
F5D5050.

Signed-off-by: Rafael Kitover <rkitover@gmail.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 73859
Build 70742: arc lint + arc unit

Event Timeline

rkitover_gmail.com created this revision.Sun, Jun 14, 3:28 AM

Herald added a subscriber: imp. · View Herald TranscriptSun, Jun 14, 3:28 AM

rkitover_gmail.com requested review of this revision.Sun, Jun 14, 3:28 AM

Harbormaster completed remote builds in B73859: Diff 179706.Sun, Jun 14, 3:28 AM

Add Differential Review to commit message

Harbormaster completed remote builds in B73860: Diff 179707.Sun, Jun 14, 3:30 AM

rkitover_gmail.com added projects: USB, desktop.Sun, Jun 14, 3:31 AM

rkitover_gmail.com mentioned this in D57566: aue(4): fix incorrect media detection.Sun, Jun 14, 3:36 AM

rkitover_gmail.com mentioned this in D55631: axge: fix spurious link down from MII, frozen TX.

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

net/

if_aue.c

25 lines

if_auereg.h

4 lines

Diff 179706

View Options

sys/dev/usb/net/if_aue.c