emulators/rvvm-devel: new port
Needs ReviewPublic
Actions

Authored by siva on Wed, Feb 18, 4:14 PM.

Details

Reviewers

fuz

Summary

As noted here in the 0.6 release notes[0], upstream now recommends using
nightly builds instead of the 0.6 release.

NOTE: RVVM nightly builds should be preferred, this release is for historical reference.

This new port tracks nightly builds and brings in 1400+ commits
of improvements.

This commit also has the following changes:

Now that the upstream Makefile's test target automatically downloads test sources, remove the dependency on test sources and allow the test target to download them on-demand
Add pkgconfig to automatically detect correct X11 CFLAGS and LDFLAGS
Use the correct USE_* options to disable x11 and graphics
Remove patch-Makefile, which doesn't apply anymore (none of the changes are needed in the upstream Makefile)

Tested by two methods:

'poudriere testport' and 'make test' (passed)
booting FreeBSD 15-STABLE with RVVM and running 'kyua test' in /usr/tests inside the guest. (passed)

[0] https://github.com/LekKit/RVVM/releases/tag/v0.6

Test Plan

Tested by two methods:

'poudriere testport' and 'make test' (passed)
booting FreeBSD 15-STABLE with RVVM and running 'kyua test' in /usr/tests inside the guest. (passed)

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70759
Build 67642: arc lint + arc unit

Event Timeline

siva requested review of this revision.Wed, Feb 18, 4:14 PM

siva created this revision.

Harbormaster completed remote builds in B70759: Diff 172181.Wed, Feb 18, 4:14 PM

I am not going to do this as per policy.
This patch is REJECTED.

We can however provide an emulators/rvvm-devel with the most recent git snapshot if desired.

Thanks for the feedback. I like the plan of going ahead with emulators/rvvm-devel. I'd like to start using this in projects like Bricoler to speed up riscv64 CI and clean up failing tests, so tracking the latest improvements is important to me.

I've kept you as the maintainer for the new port, but I'd be happy to maintain it too. What do you think?

I already have an update to an older development snapshot prepared and will work off that.
There is no need to update this patch, as I do not plan to use it.
Note that it needs rework in any case, for example, we do not permit downloading of files after the fetch phase, so “allow the test target to download them on-demand” is incorrect and will fail in a Poudriere jail.

I already have an update to an older development snapshot prepared and will work off that.

Sounds good, please publish it when you get time, I'd like to bring that into my local tree and start using it.

There is no need to update this patch, as I do not plan to use it.

No problem, I'll abandon it after discussion.

Note that it needs rework in any case, for example, we do not permit downloading of files after the fetch phase, so “allow the test target to download them on-demand” is incorrect and will fail in a Poudriere jail.

This does not fail in a poudriere jail. I am running make test within poudriere testport -i, which allows me to run tests just fine (it does have access to the internet in poudriere's default configuration). As I understand, it's just that stages after fetch do not allow networking. In any case, tests are manually run.

However, since this patch is being abandoned, it doesn't matter too much since you'll be taking over with your own rvvm-devel port.