Differential D54208

x11/kde: Align descriptions with upstream more
ClosedPublic
Actions

Authored by ziaee on Sat, Dec 13, 11:46 AM.

Tags

None

Referenced Files

	F140044513: D54208.id168266.diff
	Fri, Dec 19, 11:23 AM

	Unknown Object (File)
	Thu, Dec 18, 3:15 PM

	Unknown Object (File)
	Thu, Dec 18, 3:15 PM

	Unknown Object (File)
	Wed, Dec 17, 9:46 PM

	Unknown Object (File)
	Wed, Dec 17, 5:20 PM

	Unknown Object (File)
	Tue, Dec 16, 11:48 PM

	Unknown Object (File)
	Mon, Dec 15, 11:54 AM

	Unknown Object (File)
	Mon, Dec 15, 10:35 AM

View All 12 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

R11:cf0955e9628b: x11/kde: Align descriptions with upstream more

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69335
Build 66218: arc lint + arc unit

Event Timeline

ziaee requested review of this revision.Sat, Dec 13, 11:46 AM

ziaee created this revision.

Harbormaster completed remote builds in B69231: Diff 167966.Sat, Dec 13, 11:46 AM

ziaee added inline comments.Sat, Dec 13, 11:47 AM

x11/kde/pkg-descr
2	Honestly, Linux is a type of Unix workstation and I feel that we should remove Linux here.

makc added a subscriber: makc.Sat, Dec 13, 1:49 PM

makc added inline comments.

x11/kde/pkg-descr
4–8	No, Frameworks are provided by x11/kf6-frameworks meta port. No need to mention Frameworks here.

update

Harbormaster completed remote builds in B69308: Diff 168207.Tue, Dec 16, 6:08 PM

makc added inline comments.Tue, Dec 16, 7:00 PM

x11/plasma6-plasma/Makefile
7	Not sure about this change. "KDE Plasma 6" is fine and widely used. See, for example, announcement for KDE Plasma release: https://kde.org/announcements/plasma/6/6.5.4/

"Plasma 6 Desktop by KDE" > "KDE Plasma 6 Desktop"
I still think adding desktop to the -c is a value-add.

Harbormaster completed remote builds in B69335: Diff 168266.Wed, Dec 17, 3:34 PM

In D54208#1240141, @ziaee wrote:

"Plasma 6 Desktop by KDE" > "KDE Plasma 6 Desktop"
I still think adding desktop to the -c is a value-add.

Sure, thank you!

This revision is now accepted and ready to land.Wed, Dec 17, 6:06 PM

Closed by commit R11:cf0955e9628b: x11/kde: Align descriptions with upstream more (authored by ziaee). · Explain WhyThu, Dec 18, 2:56 PM

This revision was automatically updated to reflect the committed changes.

ziaee added a commit: R11:cf0955e9628b: x11/kde: Align descriptions with upstream more.

Revision Contents
Changeset List

Path

Size

x11/

kde/

4 lines

11 lines

plasma6-plasma/

2 lines

Diff 168266

x11/kde/Makefile

Loading...

x11/kde/pkg-descr

Loading...

x11/plasma6-plasma/Makefile

Loading...