2.1.0-20250707
ClosedPublic
Actions

Authored by alven on Tue, Oct 7, 8:04 PM.

Details

Reviewers

db
yuri

Commits

R11:cf8635a1d5e4: cad/opentimer: Update g20221116 => 2.1.0-20250707

Summary

Unbreak on i386 and powerpc
Add optional DOCS and EXAMPLES
Pet portclippy(1) and portfmt(1)

Test Plan

For every {amd64, i386} × {14.3, 13.5}:

Successful poudriere testport
Successful run-testing

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 67649
Build 64532: arc lint + arc unit

Event Timeline

alven requested review of this revision.Tue, Oct 7, 8:04 PM

alven created this revision.

Harbormaster completed remote builds in B67624: Diff 163722.Tue, Oct 7, 8:04 PM

yuri added inline comments.Wed, Oct 8, 7:25 AM

cad/opentimer/Makefile
2	This line should be: DISTVERSION= 2.1.0-20250707 the 'g' syntax is used when there are no tag and no version. In this case the version is present. 20250707 would become the last part of the version.

Fix DISTVERSION

Harbormaster completed remote builds in B67642: Diff 163763.Wed, Oct 8, 11:12 AM

alven retitled this revision from cad/opentimer: Update g20221116 => 2.1.0-g20250707 to cad/opentimer: Update g20221116 => 2.1.0-20250707.Wed, Oct 8, 11:12 AM

yuri requested changes to this revision.Wed, Oct 8, 2:07 PM

yuri added inline comments.

cad/opentimer/Makefile
40	Please remove surrounding braces. People often think that they are needed, but in fact they aren't needed in the BSD Make syntax.
45	Please remove surrounding braces.
45	Please remove surrounding braces.
cad/opentimer/pkg-plist
1 ↗	(On Diff #163763)	Please use PORTEXAMPLES=* in the Makefile and remove the list of examples from pkg-plist. Examples aren't as "important" as other files and it's advantageous to not have their list to keep pkg-plist shorter.
57 ↗	(On Diff #163763)	Same as with examples.