Page MenuHomeFreeBSD
Differential D51737

devel/lace: update to 1.5.1
ClosedPublic
Actions

Authored by fuz on Tue, Aug 5, 11:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 11, 4:48 AM
Unknown Object (File)
Fri, Aug 8, 6:08 PM
Unknown Object (File)
Wed, Aug 6, 3:42 PM
Unknown Object (File)
Wed, Aug 6, 3:26 PM
Unknown Object (File)
Wed, Aug 6, 3:13 AM
Subscribers
None

Details

Reviewers
yuri
Commits
R11:2fffeac66b48: devel/lace14: update to 1.5.1
R11:597f4a1397b6: devel/lace: Remove hardcoded 'native'; Fix build on i386
R11:38cb7e8a7137: math/oink: Fix build by using devel/lace14
Summary

This fixes the build problems on ARM. However, one of the unit tests
still fails on armv7 and arm64.

Changelog: https://github.com/trolando/lace/blob/lace-1/CHANGELOG.md

Approved by: ...
See also: https://github.com/trolando/lace/issues/16

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fuz requested review of this revision.Tue, Aug 5, 11:02 AM
fuz created this revision.
Harbormaster completed remote builds in B65968: Diff 159753.Tue, Aug 5, 11:02 AM
yuri added a comment.Tue, Aug 5, 3:52 PM

devel/lace is currently at the version 2.0.2

Are you looking at the quarterly branch?

fuz added a comment.Tue, Aug 5, 4:33 PM

I started to investigate this issue before you committed the update.

Did you test if lace 2 works with math/oink? Upstream renamed many identifiers and I don't see how it still works.

fuz added a comment.Tue, Aug 5, 4:34 PM

Just checked, it does not work. So you upgraded devel/lace to a new major version without checking if its sole reverse dependency still builds with it...

yuri added a comment.Wed, Aug 6, 3:15 PM

You are right.
This is fixed now.

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Aug 6, 3:15 PM
Closed by commit R11:38cb7e8a7137: math/oink: Fix build by using devel/lace14 (authored by yuri). · Explain Why
This revision was automatically updated to reflect the committed changes.
yuri added a commit: R11:38cb7e8a7137: math/oink: Fix build by using devel/lace14.
yuri added a commit: R11:597f4a1397b6: devel/lace: Remove hardcoded 'native'; Fix build on i386.Wed, Aug 6, 3:28 PM
fuz added a comment.Wed, Aug 6, 4:43 PM

devel/lace14 is still at 1.4.2 now. Can I commit this update to that new port?

yuri added a comment.Thu, Aug 7, 4:21 AM
In D51737#1182586, @fuz wrote:

devel/lace14 is still at 1.4.2 now. Can I commit this update to that new port?

What changes do you want to commit?
I picked all changes from the patch here.

fuz added a comment.Thu, Aug 7, 8:19 AM

The one that updates the port to 1.5.1. Which was the main point of this changeset.

yuri added a comment.Thu, Aug 7, 8:23 AM
In D51737#1183049, @fuz wrote:

The one that updates the port to 1.5.1. Which was the main point of this changeset.

I see.

Then please move it to lace15 as well.

fuz added a commit: R11:2fffeac66b48: devel/lace14: update to 1.5.1.Sun, Aug 10, 7:17 PM

Revision Contents
Changeset List

PathSize
math/
oink/
2 lines

Diff 159870

View Options

math/oink/Makefile

Loading...