LIBGLMAP
AcceptedPublic
Actions

Authored by kbowling on Sun, Apr 27, 11:21 PM.

Details

Reviewers

ashafer
danfe
junchoon_dec.sakura.ne.jp

Summary

As of 972708f1d3948f9805f20c8ec7a90e9034009edd we do not need this functionality.

This leaves EXTENSIONSDIR in place because it is still handled in the main Makefile and I am not sure if there is any other way to deal with that particular situation.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kbowling requested review of this revision.Sun, Apr 27, 11:21 PM

kbowling created this revision.

junchoon_dec.sakura.ne.jp added inline comments.Mon, Apr 28, 9:13 AM

x11/nvidia-driver/Makefile
416	As seen in the comment above, this .if block is the remnant of x11/nvidia-secondary-driver. No other ports overrides EXTENSIONSDIR variable. But possibly there could be some use-cases (would be site-local usages) and anyone could want this to be kept. So removing after heads-ups with timeouts would be safer not to violate POLA.

ashafer added inline comments.Mon, Apr 28, 2:02 PM

x11/nvidia-driver/Makefile
416	Also if we are cleaning up old driver support this isn't needed since 410, so probably a good candidate to remove anyway.

kbowling updated this revision to Diff 154529.Wed, Apr 30, 5:58 AM

kbowling marked 2 inline comments as done.

kbowling added inline comments.

x11/nvidia-driver/Makefile
416	Also if we are cleaning up old driver support this isn't needed since 410, so probably a good candidate to remove anyway. It's a little confusing but this still applies to i.e. nvidia-driver-390. I think it is ok to leave the exact version as is for historical reference.

Even though I've left inline comment about PORTREVISION, others looks good to me.
So accepting now.
Modifying PORTREVISION to match reality at the time committed shouldn't matter,
but if you want on commit, I'll accept this again ASAP.

x11/nvidia-driver/Makefile
17	PORTREVISION should be bumped, but the value should depend on the timing this lands. Some backgrounds for the future not to be forgotton: If D50053 (rework of already-landed D49828) lands earlier, this should be 4. But if this D50048 lands earlier, this should be 3 and D50053 should have PORTREVISION 4. If any others lands earlier, it may vary. Note that D50053 would be the show-stopper for D49982 (upgrade to 570.144).