Managing Contributor Lists
Details
- Reviewers
dbaio - Group Reviewers
docs doceng - Commits
- R9:7cad8b831fc4: fdp-primer: Add Managing Contributor Lists section
Diff Detail
- Repository
- R9 FreeBSD doc repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 62701 Build 59585: arc lint + arc unit
Event Timeline
Hi,
Thank you for submitting this improvement.
| documentation/content/en/books/fdp-primer/structure/_index.adoc | ||
|---|---|---|
| 146 | Please move this section to the bottom, after the "Books" and "Articles" sections. | |
| 153 | Use the extref macro here. | |
| 226 | s/though/through | |
| 227 | There is a hidden part here for people on the In Memoriam; we usually comment out the email part just to avoid creating the email link "mailto:" See itojun: [shared/authors.adoc]
[..]
:itojun-name: Jun-ichiro Itoh
:itojun-email: \itojun@FreeBSD.org
:itojun: {itojun-name} <{itojun-email}>
:ivadasz-name: Imre Vadasz
:ivadasz-email: ivadasz@FreeBSD.org
:ivadasz: {ivadasz-name} <{ivadasz-email}>
[..] | |
Please refer to the file names using the following format:
[.filename]#doc/shared/contrib-committers.adoc#
...
About Phabricator,
The current code here reflects the changes you made since your last commit; we need to see everything. If you made changes in the last two or three commits, you need to include all those changes when updating the review. For example:
To include the last two commits, type:
arc diff --update D49185 HEAD~2
To include the last three commits, type:
arc diff --update D49185 HEAD~3
| documentation/content/en/books/fdp-primer/structure/_index.adoc | ||
|---|---|---|
| 416 | This references the 'Additional FreeBSD Contributors' and not the 'FreeBSD Derived Software Contributors' | |
With the complete updates, I can load the review in my environment using arc patch D49185. Then, I can build it and see your changes live.
I'll make a slight change to the introductory phrase and push this through.
Thanks for your work.
| documentation/content/en/books/fdp-primer/structure/_index.adoc | ||
|---|---|---|
| 353 | The FreeBSD project recognizes contributors in several different lists in the documentation and in printed materials. | |