Page MenuHomeFreeBSD

[fdp] Managing Contributor Lists
ClosedPublic

Authored by jpb_jimby.name on Fri, Feb 28, 10:58 PM.
Tags
None
Referenced Files
F111992335: D49185.id151705.diff
Tue, Mar 11, 7:04 AM
Unknown Object (File)
Mon, Mar 10, 7:21 AM
Unknown Object (File)
Sun, Mar 9, 12:48 PM
Unknown Object (File)
Sat, Mar 8, 7:35 AM
Unknown Object (File)
Tue, Mar 4, 6:07 PM
Unknown Object (File)
Tue, Mar 4, 5:48 PM
Unknown Object (File)
Sun, Mar 2, 12:45 AM
Unknown Object (File)
Sun, Mar 2, 12:12 AM
Subscribers

Details

Summary

Managing Contributor Lists

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jpb_jimby.name created this revision.
dbaio requested changes to this revision.Sat, Mar 1, 4:51 PM
dbaio added a subscriber: dbaio.

Hi,

Thank you for submitting this improvement.

documentation/content/en/books/fdp-primer/structure/_index.adoc
146

Please move this section to the bottom, after the "Books" and "Articles" sections.

153
226

s/though/through

227

There is a hidden part here for people on the In Memoriam; we usually comment out the email part just to avoid creating the email link "mailto:"

See itojun:

[shared/authors.adoc]

[..]

:itojun-name: Jun-ichiro Itoh
:itojun-email: \itojun@FreeBSD.org
:itojun: {itojun-name} <{itojun-email}>

:ivadasz-name: Imre Vadasz
:ivadasz-email: ivadasz@FreeBSD.org
:ivadasz: {ivadasz-name} <{ivadasz-email}>

[..]
This revision now requires changes to proceed.Sat, Mar 1, 4:51 PM

Changes made as requested.

[fdp] Managing Contributor Lists

Please refer to the file names using the following format:

[.filename]#doc/shared/contrib-committers.adoc#

...

About Phabricator,

The current code here reflects the changes you made since your last commit; we need to see everything. If you made changes in the last two or three commits, you need to include all those changes when updating the review. For example:

To include the last two commits, type:
arc diff --update D49185 HEAD~2

To include the last three commits, type:
arc diff --update D49185 HEAD~3

documentation/content/en/books/fdp-primer/structure/_index.adoc
327

This references the 'Additional FreeBSD Contributors' and not the 'FreeBSD Derived Software Contributors'

About Phabricator,

The current code here reflects the changes you made since your last commit; we need to see everything. If you made changes in the last two or three commits, you need to include all those changes when updating the review. For example:

To include the last two commits, type:
arc diff --update D49185 HEAD~2

To include the last three commits, type:
arc diff --update D49185 HEAD~3

With the complete updates, I can load the review in my environment using arc patch D49185. Then, I can build it and see your changes live.

Completed additional changes as requested.

  • [fdp] Managing Contributor Lists

I'll make a slight change to the introductory phrase and push this through.
Thanks for your work.

documentation/content/en/books/fdp-primer/structure/_index.adoc
264

The FreeBSD project recognizes contributors in several different lists in the documentation and in printed materials.

This revision is now accepted and ready to land.Sun, Mar 2, 5:55 PM