articles/nanobsd: Cleanup and typo fixes
Needs ReviewPublic
Actions

Authored by jlduran on Nov 16 2024, 7:50 AM.

Details

Reviewers: None

Summary

Document some missing usage options as well.

Diff Detail

Repository

R9 FreeBSD doc repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60626
Build 57510: arc lint + arc unit

Event Timeline

jlduran requested review of this revision.Nov 16 2024, 7:50 AM

jlduran created this revision.

Harbormaster completed remote builds in B60626: Diff 146584.Nov 16 2024, 7:50 AM

jlduran mentioned this in D47643: nanobsd: Increase default media size.Nov 17 2024, 12:10 AM

Revision Contents
Changeset List

Path

Size

documentation/

content/

en/

articles/

nanobsd/

_index.adoc

63 lines

Diff 146584

View Options

documentation/content/en/articles/nanobsd/_index.adoc

Show First 20 Lines • Show All 190 Lines • ▼ Show 20 Lines	main(int argc, char *argv[])
}		}

compile();		compile();

/* Continue with first and start second usage */		/* Continue with first and start second usage */
if (*argv)		if (*argv)
for (; *argv; argv++)		for (; *argv; argv++)
add_file(*argv);		add_file(*argv);
else if (fflagstdin)		else if (fflagstdin)
		0mpAuthorUnsubmitted Done Inline Actions There has to be at least one input file specified. 0mp: There has to be at least one input file specified.
exit(rval);		exit(rval);
else		else
add_file(NULL);		add_file(NULL);
process();		process();
cfclose(prog, NULL);		cfclose(prog, NULL);
if (fclose(stdout))		if (fclose(stdout))
err(1, "stdout");		err(1, "stdout");
exit(rval);		exit(rval);
Show All 29 Lines	if (script == NULL) {
if (more != NULL)		if (more != NULL)
*more = 0;		*more = 0;
return (NULL);		return (NULL);
}		}
linenum = 0;		linenum = 0;
switch (script->type) {		switch (script->type) {
case CU_FILE:		case CU_FILE:
if (strcmp(script->s, "-") == 0) {		if (strcmp(script->s, "-") == 0) {
if ((f = fdopen(0, "r")) == NULL)		f = stdin;
		0mpAuthorUnsubmitted Done Inline Actions I am not sure if it makes any difference if I try to avoid depending on the presence of `/dev/stdin` by using the 0th descriptor here instead. 0mp: I am not sure if it makes any difference if I try to avoid depending on the presence of…
err(1, "%s", "stdin");
fname = "stdin";		fname = "stdin";
		tobikUnsubmitted Done Inline Actions Can this not just be `f = stdin`? tobik: Can this not just be `f = stdin`?
		0mpAuthorUnsubmitted Done Inline Actions Good catch! The tests are still passing. 0mp: Good catch! The tests are still passing.
} else {		} else {
		0mpAuthorUnsubmitted Done Inline Actions Is `stdin` name here alright? Perhaps it could be changed to `-`? 0mp: Is `stdin` name here alright? Perhaps it could be changed to `-`?
if ((f = fopen(script->s, "r")) == NULL)		if ((f = fopen(script->s, "r")) == NULL)
err(1, "%s", script->s);		err(1, "%s", script->s);
fname = script->s;		fname = script->s;
}		}
state = ST_FILE;		state = ST_FILE;
goto again;		goto again;
case CU_STRING:		case CU_STRING:
if (((size_t)snprintf(string_ident,		if (((size_t)snprintf(string_ident,
▲ Show 20 Lines • Show All 302 Lines • Show Last 20 Lines

articles/nanobsd: Cleanup and typo fixesNeeds ReviewPublicActions