Make phabricator access work with php 8.4.0RC3.
ClosedPublic
Actions

Authored by grembo on Oct 31 2024, 10:59 PM.

Details

Reviewers

cracauer
grembo

Commits

R11:798fa7e21115: devel/arcanist-lib: Fix for PHP 8.4.0RC3 (revisited)
R11:baae1af5e904: devel/arcanist-lib: Fix for PHP 8.4.0RC3

Summary

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60314
Build 57198: arc lint + arc unit

Event Timeline

cracauer requested review of this revision.Oct 31 2024, 10:59 PM

cracauer created this revision.

Harbormaster completed remote builds in B60314: Diff 145812.Oct 31 2024, 11:00 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 11 2024, 5:03 PM

Closed by commit R11:baae1af5e904: devel/arcanist-lib: Fix for PHP 8.4.0RC3 (authored by grembo). · Explain Why

This revision was automatically updated to reflect the committed changes.

grembo added a commit: R11:baae1af5e904: devel/arcanist-lib: Fix for PHP 8.4.0RC3.

@cracauer Thank you

grembo added a commit: R11:798fa7e21115: devel/arcanist-lib: Fix for PHP 8.4.0RC3 (revisited).Nov 11 2024, 5:06 PM

Interesting, what I committed basically overwrote your correct patch (but only once). The port was fixed eventually.

Attempting to fix the differential so it looks not as weird as it does. Sorry #facepalm

grembo accepted this revision.Nov 11 2024, 5:11 PM

This revision is now accepted and ready to land.Nov 11 2024, 5:11 PM

grembo closed this revision.Nov 11 2024, 5:11 PM

Revision Contents
Changeset List

Path

Size

devel/

arcanist-lib/

files/

patch-src_future_FutureProxy.php

11 lines

Diff 145812

View Options

devel/arcanist-lib/files/patch-src_future_FutureProxy.php

Make phabricator access work with php 8.4.0RC3.ClosedPublicActions