databases/pgbackrest: update to 2.51
ClosedPublic
Actions

Authored by uzsolt on Apr 14 2024, 4:14 PM.

Details

Reviewers

bofh
diizzy

Commits

R11:43ecb9346397: databases/pgbackrest: update to 2.51

Summary

Switch to meson build system.
Rename option SSH to SFTP.
Changelog: https://pgbackrest.org/release.html#2.51

PR: 276559
Approved by: bofh (mentor) OR diizzy (mentor)
(Differential Revision: https://reviews.freebsd.org/D###)

Test Plan

Portlint, portfmt, portclippy look fine.
Poudriere testport passed on 13.2, 13.3, 14.0 (amd64).

The commit will be git commit -a --author='Michael Schout <schoutm@gmail.com>'

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

uzsolt requested review of this revision.Apr 14 2024, 4:14 PM

uzsolt created this revision.

Harbormaster completed remote builds in B57099: Diff 137019.Apr 14 2024, 4:14 PM

diizzy added inline comments.Apr 20 2024, 10:59 PM

databases/pgbackrest/Makefile
22	Not a hard requirement but it would be nice if we could fix this with helpers and/or upstream If it's within Meson https://github.com/HOST-Oman/libraqm/pull/146/files might help
30	Use helpers https://docs.freebsd.org/en/books/porters-handbook/book/#options-meson_enabled

Where do the patches originate and are they upstreamed?

In D44791#1023359, @diizzy wrote:

Where do the patches originate and are they upstreamed?

Here it is: https://github.com/pgbackrest/pgbackrest/commit/7b95fd3bd29346e7325aa161bfee45efd71e22eb
The port maintainer is the author of patch.

How should handle it in the port?

In D44791#1023899, @uzsolt wrote:

In D44791#1023359, @diizzy wrote:

Where do the patches originate and are they upstreamed?

Here it is: https://github.com/pgbackrest/pgbackrest/commit/7b95fd3bd29346e7325aa161bfee45efd71e22eb
The port maintainer is the author of patch.

How should handle it in the port?

Use of GH_TAGNAME would be better than patches? Or the Example 18. in Porter's Handbook?

In D44791#1025107, @uzsolt wrote:

In D44791#1023899, @uzsolt wrote:

In D44791#1023359, @diizzy wrote:

Where do the patches originate and are they upstreamed?

Here it is: https://github.com/pgbackrest/pgbackrest/commit/7b95fd3bd29346e7325aa161bfee45efd71e22eb
The port maintainer is the author of patch.

How should handle it in the port?

Use of GH_TAGNAME would be better than patches? Or the Example 18. in Porter's Handbook?

No, avoid "applying" patches that way when tracking releases.

If possible fetch it (unless it's hosted on Gitlab/Gitlab instance) otherwise apply it to the port like already done here, just be sure to reference origin to make it easier to the next person.

https://cgit.freebsd.org/ports/commit/irc/irssi/Makefile?id=bc97cc7b70dea8f491605a7670932805dcb9ea97

Best regards,
Daniel

This revision is now accepted and ready to land.Apr 26 2024, 6:26 PM

Closed by commit R11:43ecb9346397: databases/pgbackrest: update to 2.51 (authored by Michael Schout <schoutm@gmail.com>, committed by uzsolt). · Explain WhyApr 27 2024, 5:49 AM

This revision was automatically updated to reflect the committed changes.

uzsolt added a commit: R11:43ecb9346397: databases/pgbackrest: update to 2.51.