databases/pgbackrest: update to 2.51

[uzsolt]

Summary

Switch to meson build system.
Rename option SSH to SFTP.
Changelog: https://pgbackrest.org/release.html#2.51

PR: 276559
Approved by: bofh (mentor) OR diizzy (mentor)
(Differential Revision: https://reviews.freebsd.org/D###)

Test Plan

Portlint, portfmt, portclippy look fine.
Poudriere testport passed on 13.2, 13.3, 14.0 (amd64).

The commit will be git commit -a --author='Michael Schout <[e-mail]>'

[diizzy]

databases/pgbackrest/Makefile

22

Not a hard requirement but it would be nice if we could fix this with helpers and/or upstream
If it's within Meson https://github.com/HOST-Oman/libraqm/pull/146/files might help

30

Use helpers
https://docs.freebsd.org/en/books/porters-handbook/book/#options-meson_enabled

[diizzy]

Where do the patches originate and are they upstreamed?

[uzsolt]

In D44791#1023359, @diizzy wrote:

Where do the patches originate and are they upstreamed?

Here it is: https://github.com/pgbackrest/pgbackrest/commit/7b95fd3bd29346e7325aa161bfee45efd71e22eb
The port maintainer is the author of patch.

How should handle it in the port?

[uzsolt]

In D44791#1023899, @uzsolt wrote:

In D44791#1023359, @diizzy wrote:

Where do the patches originate and are they upstreamed?

Here it is: https://github.com/pgbackrest/pgbackrest/commit/7b95fd3bd29346e7325aa161bfee45efd71e22eb
The port maintainer is the author of patch.

How should handle it in the port?

Use of GH_TAGNAME would be better than patches? Or the Example 18. in Porter's Handbook?

[diizzy]

In D44791#1025107, @uzsolt wrote:

In D44791#1023899, @uzsolt wrote:

In D44791#1023359, @diizzy wrote:

Where do the patches originate and are they upstreamed?

Here it is: https://github.com/pgbackrest/pgbackrest/commit/7b95fd3bd29346e7325aa161bfee45efd71e22eb
The port maintainer is the author of patch.

How should handle it in the port?

Use of GH_TAGNAME would be better than patches? Or the Example 18. in Porter's Handbook?

No, avoid "applying" patches that way when tracking releases.

If possible fetch it (unless it's hosted on Gitlab/Gitlab instance) otherwise apply it to the port like already done here, just be sure to reference origin to make it easier to the next person.

https://cgit.freebsd.org/ports/commit/irc/irssi/Makefile?id=bc97cc7b70dea8f491605a7670932805dcb9ea97

Best regards,
Daniel