Page MenuHomeFreeBSD
Differential D43881

x11-wm/herbstluftwm: remove bashizm
ClosedPublic
Actions

Authored by uzsolt on Feb 14 2024, 4:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 7, 1:22 PM
Unknown Object (File)
Mon, Jul 7, 1:21 PM
Unknown Object (File)
Fri, Jul 4, 1:15 AM
Unknown Object (File)
Fri, Jun 20, 7:31 PM
Unknown Object (File)
Tue, Jun 17, 10:27 PM
Unknown Object (File)
Jun 13 2025, 11:02 AM
Unknown Object (File)
Jun 12 2025, 11:01 AM
Unknown Object (File)
Jun 9 2025, 6:10 PM
View All 48 Files
Subscribers
None

Details

Reviewers
bofh
diizzy
uzsolt
Summary

The bashizm removed from autostart file (see https://reviews.freebsd.org/D20457 and https://reviews.freebsd.org/D20004) but the shebang line wasn't fixed.

Portlint, portfmt and portclippy are fine (needed some small fixes).
Poudriere testports are fine on amd64 13.2 and 14.0.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

uzsolt requested review of this revision.Feb 14 2024, 4:55 PM
uzsolt created this revision.
diizzy added inline comments.Feb 25 2024, 12:59 PM
x11-wm/herbstluftwm/Makefile
13

Fix this while at it, += --> =

26

Fix this while at it, += --> =

29

Please have a look if you can fix this properly upstream or possibly use shebangfix instead

x11-wm/herbstluftwm/files/patch-share_autostart
5

Upstreamed?

uzsolt updated this revision to Diff 134980.Feb 25 2024, 3:26 PM

Fixes.

bofh added a comment.Mar 2 2024, 10:52 AM

My knowledge on the x11 stuff is a bit rusty so I will refrain from reviewing this.

uzsolt accepted this revision.Sat, Jun 21, 5:54 PM
uzsolt marked 3 inline comments as done.
uzsolt added inline comments.
x11-wm/herbstluftwm/Makefile
29

It works well with shebangfix. Thanks.

x11-wm/herbstluftwm/files/patch-share_autostart
5

Fixed a small error ($key -> $i).

This revision is now accepted and ready to land.Sat, Jun 21, 5:54 PM
uzsolt closed this revision.Sat, Jun 21, 5:54 PM
uzsolt marked an inline comment as done.

Revision Contents
Changeset List

PathSize
x11-wm/
herbstluftwm/
14 lines
files/
18 lines
3 lines

Diff 134980

View Options

x11-wm/herbstluftwm/Makefile

Loading...
View Options

x11-wm/herbstluftwm/files/patch-share_autostart

Loading...
View Options

x11-wm/herbstluftwm/files/pkg-message.in

Loading...