Page MenuHomeFreeBSD
Differential D42973

mail/dbmail: remove dead sbrk linkage
ClosedPublic
Actions

Authored by brooks on Dec 8 2023, 10:43 PM.
Tags
None
Referenced Files
F124479436: D42973.diff
Sun, Jul 27, 3:30 AM
Unknown Object (File)
Jun 15 2025, 2:54 AM
Unknown Object (File)
Jun 13 2025, 11:23 PM
Unknown Object (File)
Jun 7 2025, 7:23 PM
Unknown Object (File)
May 31 2025, 3:27 PM
Unknown Object (File)
May 28 2025, 1:48 AM
Unknown Object (File)
May 20 2025, 1:18 AM
Unknown Object (File)
May 10 2025, 1:03 AM
View All 36 Files
Subscribers
None

Details

Reviewers
bofh
Commits
R11:c59c5adc46f3: mail/dbmail: Remove dead sbrk linkage
Summary

Somewhat more throughly disable dead code paths that use sbrk.
(MPOOL_FLAG_USE_SBRK is only set of a const variable that is set to 0 is
true so this is entierly dead code.)

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks requested review of this revision.Dec 8 2023, 10:43 PM
brooks created this revision.
Harbormaster completed remote builds in B54867: Diff 131188.Dec 8 2023, 10:43 PM
brooks added a comment.Dec 8 2023, 10:51 PM

Compile tested only on an amd64 userspace without sbrk.

bofh added a comment.Dec 9 2023, 8:04 AM

Looking into it. If build is successful will commit.

bofh added a comment.Dec 9 2023, 8:18 AM

Looks buildable. Will commit in my next batch.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 10 2023, 2:57 PM
Closed by commit R11:c59c5adc46f3: mail/dbmail: Remove dead sbrk linkage (authored by brooks, committed by bofh). · Explain Why
This revision was automatically updated to reflect the committed changes.
bofh added a commit: R11:c59c5adc46f3: mail/dbmail: Remove dead sbrk linkage.

Revision Contents
Changeset List

PathSize
mail/
dbmail/
3 lines
files/
38 lines

Diff 131230

View Options

mail/dbmail/Makefile

Loading...
View Options

mail/dbmail/files/patch-src_mpool_mpool.c

Loading...