Page MenuHomeFreeBSD
Differential D42973

mail/dbmail: remove dead sbrk linkage
ClosedPublic
Actions

Authored by brooks on Dec 8 2023, 10:43 PM.
Tags
None
Referenced Files
F149897626: D42973.id.diff
Fri, Mar 27, 11:33 PM
Unknown Object (File)
Sun, Mar 22, 5:04 AM
Unknown Object (File)
Sat, Mar 21, 7:35 PM
Unknown Object (File)
Mon, Mar 16, 10:02 AM
Unknown Object (File)
Sat, Feb 28, 1:41 AM
Unknown Object (File)
Feb 10 2026, 11:45 AM
Unknown Object (File)
Jan 26 2026, 3:20 PM
Unknown Object (File)
Jan 10 2026, 12:02 PM
View All 77 Files
Subscribers
None

Details

Reviewers
bofh
Commits
R11:c59c5adc46f3: mail/dbmail: Remove dead sbrk linkage
Summary

Somewhat more throughly disable dead code paths that use sbrk.
(MPOOL_FLAG_USE_SBRK is only set of a const variable that is set to 0 is
true so this is entierly dead code.)

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 54867
Build 51756: arc lint + arc unit

Event Timeline

brooks requested review of this revision.Dec 8 2023, 10:43 PM
brooks created this revision.
Harbormaster completed remote builds in B54867: Diff 131188.Dec 8 2023, 10:43 PM
brooks added a comment.Dec 8 2023, 10:51 PM

Compile tested only on an amd64 userspace without sbrk.

bofh added a comment.Dec 9 2023, 8:04 AM

Looking into it. If build is successful will commit.

bofh added a comment.Dec 9 2023, 8:18 AM

Looks buildable. Will commit in my next batch.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 10 2023, 2:57 PM
Closed by commit R11:c59c5adc46f3: mail/dbmail: Remove dead sbrk linkage (authored by brooks, committed by bofh). · Explain Why
This revision was automatically updated to reflect the committed changes.
bofh added a commit: R11:c59c5adc46f3: mail/dbmail: Remove dead sbrk linkage.

Revision Contents
Changeset List

PathSize
mail/
dbmail/
3 lines
files/
38 lines

Diff 131188

View Options

mail/dbmail/Makefile

Loading...
View Options

mail/dbmail/files/patch-src_mpool_mpool.c

Loading...