Page MenuHomeFreeBSD
Differential D39564

www/{*chromium,iridium}: unbreak build with icu 73
ClosedPublic
Actions

Authored by rnagy on Apr 13 2023, 7:41 PM.
Tags
None
Referenced Files
F167251011: D39564.id120280.diff
Thu, Aug 20, 9:22 AM
F167185711: D39564.diff
Wed, Aug 19, 5:41 PM
F167185708: D39564.diff
Wed, Aug 19, 5:41 PM
Unknown Object (File)
Wed, Aug 19, 3:19 AM
Unknown Object (File)
Mon, Aug 17, 7:31 PM
Unknown Object (File)
Mon, Aug 17, 3:19 PM
Unknown Object (File)
Mon, Aug 17, 2:21 AM
Unknown Object (File)
Sat, Aug 15, 8:34 PM
View All Files
Subscribers
dhw

Details

Reviewers
rene
dhw
Summary

As of icu 73 C++ nullptr, char16_t, override, final and noexcept are used
instead of defines. These definitions can be removed when the bundled icu
gets updated to 73. For more details, see:
https://unicode-org.atlassian.net/browse/ICU-21833 and
https://github.com/unicode-org/icu/commit/28643799377ecf654564f6f31854b02788cebe33

Fixes 270817

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

rnagy requested review of this revision.Apr 13 2023, 7:41 PM
rnagy created this revision.
rene accepted this revision.Apr 13 2023, 8:40 PM

In the commit log, can you prefix the PR number with "PR: " so that the commit is logged in the PR?

This revision is now accepted and ready to land.Apr 13 2023, 8:40 PM
dhw accepted this revision.Apr 13 2023, 10:47 PM
dhw added a subscriber: dhw.

After applying the patch to my ports tree (at main-n615777-7e591c4f2380), my poudriere-devel package-builder was able to build www/chromium successfully; the resulting package installed on my laptop and appears to run as usual.

rnagy closed this revision.EditedApr 14 2023, 9:26 AM

commited as f5487f8d23309891b6faacaa9eb517f97ece429d

tagattie mentioned this in R11:db5bfb69f45b: devel/electron{21,22}: fix build with icu 73.Apr 15 2023, 2:23 PM

Revision Contents
Changeset List

PathSize
www/
chromium/
files/
18 lines
iridium/
files/
18 lines
ungoogled-chromium/
files/
18 lines

Diff 120280

View Options

www/chromium/files/patch-build_linux_unbundle_icu.gn

Loading...
View Options

www/iridium/files/patch-build_linux_unbundle_icu.gn

Loading...
View Options

www/ungoogled-chromium/files/patch-build_linux_unbundle_icu.gn

Loading...