Page MenuHomeFreeBSD

Makefile.amd64: remove construct that serves no purpose
ClosedPublic

Authored by kan on Feb 8 2023, 3:02 PM.
Tags
None
Referenced Files
F106067672: D38440.diff
Tue, Dec 24, 8:33 PM
Unknown Object (File)
Nov 24 2024, 3:07 PM
Unknown Object (File)
Oct 30 2024, 4:58 PM
Unknown Object (File)
Sep 26 2024, 7:43 PM
Unknown Object (File)
Sep 10 2024, 9:49 AM
Unknown Object (File)
Sep 4 2024, 3:43 PM
Unknown Object (File)
Aug 9 2024, 1:09 AM
Unknown Object (File)
Aug 9 2024, 1:09 AM
Subscribers
None

Details

Summary

The variable expansion as written will never match anything but
'amd64/.8' in OBJDIR. The original intention behind the construct
remains unclear, but "as is" it serves no other purpose but to
generate the warning. Remove it altogether.

Test Plan

Any 'make' invocation in usr.sbin is not nicely silent.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 49624
Build 46514: arc lint + arc unit

Event Timeline

kan requested review of this revision.Feb 8 2023, 3:02 PM
kan created this revision.

Go for it. I have this code in my tree too and it's good, but might not solve all the weird issues we see in build output now... but it's clearly completely bogus for this context. There's no man pages here, nothing to see.
If you don't do this for a day or two, I will... but I have some other, more pressing issues to attend to first.

This revision is now accepted and ready to land.Feb 8 2023, 3:39 PM
This revision was automatically updated to reflect the committed changes.