sysutils/accountsservice: update to 22.08.8
AbandonedPublic
Actions

Authored by duchateau.olivier_gmail.com on Dec 12 2022, 6:33 PM.

Details

Reviewers

None

Group Reviewers

desktop

Summary

Update to 22.08.8
Pass maintainership to desktop@ team (like other projects)
Adjust patches

Since the 22.04.62 release, ConsoleKit2 support has been removed, so we use directly libconsolekit API functions, and when they are missing the DBus API (see patch-src_libaccountsservice_act-user-manager.c).

Test Plan

With Python, it is easy to get information from user:

$ python3.9                                             
Python 3.9.15 (main, Nov 15 2022, 01:15:05) 
[Clang 13.0.0 (git@github.com:llvm/llvm-project.git llvmorg-13.0.0-0-gd7b669b3a on freebsd13
Type "help", "copyright", "credits" or "license" for more information.
>>> import gi
>>> gi.require_version('GLib', '2.0')
>>> gi.require_version('Gio', '2.0')
>>> from gi.repository import GLib, Gio
>>> bus = Gio.bus_get_sync(Gio.BusType.SYSTEM, None)
>>> proxy = Gio.DBusProxy.new_sync(bus, Gio.DBusProxyFlags.NONE, None, 'org.freedesktop.Accounts', '/org/freedesktop/Accounts', 'org.freedesktop.Accounts', None)
>>> path = proxy.FindUserByName('(s)', GLib.get_user_name())
>>> path
'/org/freedesktop/Accounts/User1001'
>>> proxy = Gio.DBusProxy.new_sync(bus, Gio.DBusProxyFlags.NONE, None, 'org.freedesktop.Accounts', path, 'org.freedesktop.DBus.Properties', None)
>>> prop = proxy.Get('(ss)', 'org.freedesktop.Accounts.User', 'IconFile')
>>> prop
'/home/olivierd/.face'
>>>

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

duchateau.olivier_gmail.com requested review of this revision.Dec 12 2022, 6:33 PM

duchateau.olivier_gmail.com created this revision.

I'd try upstreaming this first.

In D37679#856724, @arrowd wrote:

I'd try upstreaming this first.

For headers 'shadow.h' and 'crypt.h' perhaps. About ConsoleKit2 support I doubt. Support was removed almost 1 year ago, Robert Ancell already refused my patch for LightDM about internationalization (that's why it is not translated for non English users). Since the latest release, I see nobody (for BSD systems) send request or submit merge request to keep support of ConsoleKit.

You (desktop@ team) wishes to maintain libraries from freedesktop.org, so do your job!

Polkit is the same, nobody has taken time to test the latest release. SpyderMonkey >=100 is not supported by all architectures, KDE is not the only desktop supported by FreeBSD.

I didn't look into these changes yet, but why not just revert upstream commit that removed CK2 support and then build on that?

In D37679#874625, @arrowd wrote:

I didn't look into these changes yet, but why not just revert upstream commit that removed CK2 support and then build on that?

Because changes are too big. libconsolekit API is almost identical to systemd, so I think it is easier to maintain patches.

All right, we should probably get this in. Olivier, maybe you can create a fork repository containing all these patches, so we (desktop@) may participate in supporting this? I imagine this would be a non-trivial effort.

In D37679#885916, @arrowd wrote:

All right, we should probably get this in. Olivier, maybe you can create a fork repository containing all these patches, so we (desktop@) may participate in supporting this? I imagine this would be a non-trivial effort.

Why not. I think in the future, src/libaccountsservice/act-user-manager.c patch will be smaller, because @rnagy has already added these functions in development branch of consolekit2. Perhaps he knows when stable release will be published.

I've just submitted patch in order to have the latest release (23.13.9) , bug #270881.

In D37679#886005, @duchateau.olivier_gmail.com wrote:

In D37679#885916, @arrowd wrote:

All right, we should probably get this in. Olivier, maybe you can create a fork repository containing all these patches, so we (desktop@) may participate in supporting this? I imagine this would be a non-trivial effort.

Why not. I think in the future, src/libaccountsservice/act-user-manager.c patch will be smaller, because @rnagy has already added these functions in development branch of consolekit2. Perhaps he knows when stable release will be published.

consolekit2 already has all the systemd shim functions which can be used by accountsservice. So I suggest you look into that. All the required information is in
the OpenBSD ports tree and the ConsoleKit2 git repo.

In D37679#901489, @rnagy wrote:

In D37679#886005, @duchateau.olivier_gmail.com wrote:

In D37679#885916, @arrowd wrote:

All right, we should probably get this in. Olivier, maybe you can create a fork repository containing all these patches, so we (desktop@) may participate in supporting this? I imagine this would be a non-trivial effort.

Why not. I think in the future, src/libaccountsservice/act-user-manager.c patch will be smaller, because @rnagy has already added these functions in development branch of consolekit2. Perhaps he knows when stable release will be published.

consolekit2 already has all the systemd shim functions which can be used by accountsservice. So I suggest you look into that. All the required information is in
the OpenBSD ports tree and the ConsoleKit2 git repo.