Page MenuHomeFreeBSD
Differential D4467 Diff 10977 devel/py-check-manifest/Makefile

Changeset View

Standalone View

View Options

devel/py-check-manifest/Makefile

# Created by: Johannes Meixner <xmj@chaot.net> # Created by: Johannes Meixner <xmj@chaot.net>
# $FreeBSD$ # $FreeBSD$
PORTNAME= checkmanifest PORTNAME= checkmanifest
PORTVERSION= 0.22 PORTVERSION= 0.29
CATEGORIES= devel python CATEGORIES= devel python
MASTER_SITES= CHEESESHOP MASTER_SITES= CHEESESHOP
PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}
DISTNAME= check-manifest-${PORTVERSION} DISTNAME= check-manifest-${PORTVERSION}
matUnsubmitted
Not Done
Inline Actions

I think the Python rule is that the port and package should match the upstream name.

mat: I think the #python rule is that the port and package should match the upstream name.
koobsUnsubmitted
Not Done
Inline Actions

Odd, i already renamed it:

http://svnweb.freebsd.org/changeset/ports/375773
29 Dec 2014 05:54:37

?

koobs: Odd, i already renamed it: http://svnweb.freebsd.org/changeset/ports/375773 29 Dec 2014 05:54…
matUnsubmitted
Not Done
Inline Actions

Ah, but you renamed the directory, not the PORTNAME ^^
Shouldn't they both match ?

mat: Ah, but you renamed the directory, not the PORTNAME ^^ Shouldn't they both match ?
koobsUnsubmitted
Not Done
Inline Actions

WOW, I *what* ?!@ *looks*

koobs: WOW, I *what* ?!@ *looks*
koobsUnsubmitted
Not Done
Inline Actions

OH WOW. Fail

Yes, PORTNAME should be check-manifest

koobs: OH WOW. Fail Yes, PORTNAME should be check-manifest
xmjUnsubmitted
Not Done
Inline Actions

Exactly what I thought, looking at that port.

xmj: Exactly what I thought, looking at that port.
MAINTAINER= xmj@chaot.net MAINTAINER= xmj@chaot.net
COMMENT= Check MANIFEST.in in a Python source package for completeness COMMENT= Check MANIFEST.in in a Python source package for completeness
LICENSE= MIT LICENSE= MIT
LICENSE_FILE= ${WRKSRC}/LICENCE.rst LICENSE_FILE= ${WRKSRC}/LICENCE.rst
TEST_DEPENDS= ${PYTHON_PKGNAMEPREFIX}mock>0:${PORTSDIR}/devel/py-mock TEST_DEPENDS= ${PYTHON_PKGNAMEPREFIX}mock>0:${PORTSDIR}/devel/py-mock
OPTIONS_DEFINE= DOCS OPTIONS_DEFINE= DOCS
USES= python USES= python
USE_PYTHON= distutils autoplist concurrent USE_PYTHON= distutils autoplist concurrent
PORTDOCS= README.rst CHANGES.rst PORTDOCS= README.rst CHANGES.rst
post-install: post-install:
${MKDIR} ${STAGEDIR}${DOCSDIR} ${MKDIR} ${STAGEDIR}${DOCSDIR}
${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${STAGEDIR}${DOCSDIR} ${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${STAGEDIR}${DOCSDIR}
regression-test: build regression-test: build
@cd ${WRKSRC} && ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test @cd ${WRKSRC} && ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test
matUnsubmitted
Not Done
Inline Actions

This should be a test target.

mat: This should be a test target.
baptUnsubmitted
Not Done
Inline Actions

Should be imho

DO_MAKE_TEST?=-${SETENV} ${TEST_ENV} ${PYTHON_CMD} ${PYDISTUTILS_SETUP}  ${TEST_TARGET}
TEST_TARGET=test
`

Actually the DO_MAKE_TEST should probably end up in python.mk

bapt: Should be imho ``` DO_MAKE_TEST?=-${SETENV} ${TEST_ENV} ${PYTHON_CMD} ${PYDISTUTILS_SETUP}…
.include <bsd.port.mk> .include <bsd.port.mk>