Changeset View
Changeset View
Standalone View
Standalone View
documentation/content/en/articles/contributing/_index.adoc
| Show First 20 Lines • Show All 359 Lines • ▼ Show 20 Lines | |||||||||
| . Submit changes | . Submit changes | ||||||||
| + | + | ||||||||
| Send your update by submitting a PR with an explanation of the changes and a patch containing the differences between the original port and the updated one. | Send your update by submitting a PR with an explanation of the changes and a patch containing the differences between the original port and the updated one. | ||||||||
| Please refer to link:{problem-reports}[Writing FreeBSD Problem Reports] for information on how to write a really good PR. | Please refer to link:{problem-reports}[Writing FreeBSD Problem Reports] for information on how to write a really good PR. | ||||||||
| + | + | ||||||||
| [NOTE] | [NOTE] | ||||||||
| ====== | ====== | ||||||||
| Please do not submit a man:shar[1] archive of the entire port; instead, use man:diff[1] `-ruN`. | Please do not submit a man:shar[1] archive of the entire port; instead, use man:git-format-patch[1] or man:diff[1] `-ruN`. | ||||||||
| In this way, committers can much more easily see exactly what changes are being made. | In this way, committers can much more easily see exactly what changes are being made. | ||||||||
| The Porter's Handbook section on link:{porters-handbook}#port-upgrading[Upgrading] has more information. | The Porter's Handbook section on link:{porters-handbook}#port-upgrading[Upgrading] has more information. | ||||||||
| ====== | ====== | ||||||||
| . Wait | . Wait | ||||||||
| + | + | ||||||||
| At some stage a committer will deal with your PR. | At some stage a committer will deal with your PR. | ||||||||
| It may take minutes, or it may take weeks - so please be patient. | It may take minutes, or it may take one or two weeks - so please be patient. | ||||||||
bapt: instead of adding a new phrase, I would just extend the initial phrase:
```It may take minutes… | |||||||||
| If you don't get a response in certain time, seeking help on mailing lists, IRC or any place you can reach out a committer is a good idea. | |||||||||
Done Inline Actionss/doest't/don't/ jlduran_gmail.com: s/doest't/don't/ | |||||||||
Done Inline Actions
ygy: | |||||||||
pauamma_gundo.comUnsubmitted Not Done Inline Actions
Also, maybe be more specific than "a certain time"? Perhaps something like "4-6 weeks" or whatever matches actual practice? pauamma_gundo.com: Also, maybe be more specific than "a certain time"? Perhaps something like "4-6 weeks" or… | |||||||||
lwhsuAuthorUnsubmitted Done Inline ActionsI'd like to keep the current statement, originally I wanted to put "2 weeks as the maintainer timeout" but I think it is somehow too long. Maybe adding "if it exceeds 2 weeks as the maintainer timeout, you definitely need to ask for attention." ? lwhsu: I'd like to keep the current statement, originally I wanted to put "2 weeks as the maintainer… | |||||||||
pauamma_gundo.comUnsubmitted Not Done Inline ActionsThat would work for me, sez the totally-not-a-ports-expert reviewer. pauamma_gundo.com: That would work for me, sez the totally-not-a-ports-expert reviewer. | |||||||||
ygyUnsubmitted Not Done Inline Actions
ygy: | |||||||||
| . Give feedback | . Give feedback | ||||||||
| + | + | ||||||||
| If a committer finds a problem with your changes, they will most likely refer it back to you. | If a committer finds a problem with your changes, they will most likely refer it back to you. | ||||||||
| A prompt response will help get your PR committed faster, and is better for maintaining a thread of conversation when trying to resolve any problems. | A prompt response will help get your PR committed faster, and is better for maintaining a thread of conversation when trying to resolve any problems. | ||||||||
| . And Finally | . And Finally | ||||||||
| + | + | ||||||||
| Your changes will be committed and your port will have been updated. | Your changes will be committed and your port will have been updated. | ||||||||
| The PR will then be closed by the committer. That's it! | The PR will then be closed by the committer. That's it! | ||||||||
| ▲ Show 20 Lines • Show All 204 Lines • Show Last 20 Lines | |||||||||
instead of adding a new phrase, I would just extend the initial phrase: