Changeset View
Changeset View
Standalone View
Standalone View
sys/compat/linuxkpi/common/include/linux/mm.h
Show First 20 Lines • Show All 86 Lines • ▼ Show 20 Lines | |||||
#define FAULT_FLAG_ALLOW_RETRY (1 << 2) | #define FAULT_FLAG_ALLOW_RETRY (1 << 2) | ||||
#define FAULT_FLAG_RETRY_NOWAIT (1 << 3) | #define FAULT_FLAG_RETRY_NOWAIT (1 << 3) | ||||
#define FAULT_FLAG_KILLABLE (1 << 4) | #define FAULT_FLAG_KILLABLE (1 << 4) | ||||
#define FAULT_FLAG_TRIED (1 << 5) | #define FAULT_FLAG_TRIED (1 << 5) | ||||
#define FAULT_FLAG_USER (1 << 6) | #define FAULT_FLAG_USER (1 << 6) | ||||
#define FAULT_FLAG_REMOTE (1 << 7) | #define FAULT_FLAG_REMOTE (1 << 7) | ||||
#define FAULT_FLAG_INSTRUCTION (1 << 8) | #define FAULT_FLAG_INSTRUCTION (1 << 8) | ||||
#define fault_flag_allow_retry_first(flags) \ | |||||
((flags & FAULT_FLAG_ALLOW_RETRY) && (!(flags & FAULT_FLAG_TRIED))) | |||||
hselasky: Parenthesis around (flags) is good macro practice:
I suggest like this:
(((flags) &… | |||||
typedef int (*pte_fn_t)(linux_pte_t *, pgtable_t, unsigned long addr, void *data); | typedef int (*pte_fn_t)(linux_pte_t *, pgtable_t, unsigned long addr, void *data); | ||||
struct vm_area_struct { | struct vm_area_struct { | ||||
vm_offset_t vm_start; | vm_offset_t vm_start; | ||||
vm_offset_t vm_end; | vm_offset_t vm_end; | ||||
vm_offset_t vm_pgoff; | vm_offset_t vm_pgoff; | ||||
pgprot_t vm_page_prot; | pgprot_t vm_page_prot; | ||||
unsigned long vm_flags; | unsigned long vm_flags; | ||||
▲ Show 20 Lines • Show All 165 Lines • Show Last 20 Lines |
Parenthesis around (flags) is good macro practice:
I suggest like this:
(((flags) & (FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_TRIED)) == FAULT_FLAG_ALLOW_RETRY)