Changeset View
Changeset View
Standalone View
Standalone View
graphics/waffle/Makefile
| # Created by: Jean-Sébastien Pédron <dumbbell@FreeBSD.org> | # Created by: Jean-Sébastien Pédron <dumbbell@FreeBSD.org> | ||||
| # $FreeBSD$ | # $FreeBSD$ | ||||
| PORTNAME= waffle | PORTNAME= waffle | ||||
| PORTVERSION= 1.5.1 | PORTVERSION= 1.5.2 | ||||
| CATEGORIES= graphics | CATEGORIES= graphics | ||||
| MASTER_SITES= http://www.waffle-gl.org/files/release/waffle-${PORTVERSION}/ | MASTER_SITES= http://www.waffle-gl.org/files/release/waffle-${PORTVERSION}/ | ||||
| MAINTAINER= x11@FreeBSD.org | MAINTAINER= x11@FreeBSD.org | ||||
| COMMENT= Library that allows to defer selection of an OpenGL API until runtime | COMMENT= Library that allows to defer selection of an OpenGL API until runtime | ||||
| LICENSE= BSD2CLAUSE | LICENSE= BSD2CLAUSE | ||||
| USES= cmake:outsource compiler:c11 ninja pkgconfig tar:xz | USES= cmake:outsource compiler:c11 ninja pkgconfig tar:xz localbase | ||||
| USE_LDCONFIG= yes | USE_LDCONFIG= yes | ||||
| DOCSDIR= ${PREFIX}/share/doc/waffle1 | |||||
| OPTIONS_DEFINE= DOCS | |||||
| USE_XORG= x11 xcb | USE_XORG= x11 xcb | ||||
danfe: Options-related knobs are typically expected to be found near the very end of other knobs… | |||||
| USE_GL= gl egl | USE_GL= gl egl | ||||
Not Done Inline ActionsWhy these USE_* knobs are separated from the USES and USE_LDCONFIG above? danfe: Why these `USE_*` knobs are separated from the `USES` and `USE_LDCONFIG` above? | |||||
| CFLAGS+= -I${LOCALBASE}/include | |||||
| LIBS+= -L${LOCALBASE}/lib | |||||
Not Done Inline ActionsIs LIBS (vs. LDFLAGS) really correct here? If not, you might consider using USES=localbase instead. danfe: Is `LIBS` (vs. `LDFLAGS`) really correct here? If not, you might consider using… | |||||
| CMAKE_ARGS+= -Dwaffle_has_glx=ON | DOCSDIR= ${PREFIX}/share/doc/waffle1 | ||||
| #CMAKE_ARGS+= -Dwaffle_has_x11_egl=ON | |||||
| CMAKE_ARGS+= -Dwaffle_has_glx=ON \ | |||||
| -Dwaffle_has_x11_egl=ON | |||||
Not Done Inline ActionsThese two successive += statements are usually done as one. In this case it looks like it would not even cause the linewrapping. danfe: These two successive `+=` statements are usually done as one. In this case it looks like it… | |||||
| #CMAKE_ARGS+= -Dwaffle_has_gbm=ON # FIXME: Required udev | #CMAKE_ARGS+= -Dwaffle_has_gbm=ON # FIXME: Required udev | ||||
| PLIST_SUB+= PORTVERSION=${PORTVERSION} | PLIST_SUB+= PORTVERSION=${PORTVERSION} | ||||
| post-install-DOCS-off: | OPTIONS_DEFINE= DOCS | ||||
Not Done Inline ActionsI think this target is superfluous (i.e., stuff in DOCSDIR won't be packaged in docless package (ir)regardless of their presence in staging area). danfe: I think this target is superfluous (i.e., stuff in `DOCSDIR` won't be packaged in docless… | |||||
| ${RM} -rf ${STAGEDIR}${DOCSDIR} | |||||
| .include <bsd.port.mk> | .include <bsd.port.mk> | ||||
Options-related knobs are typically expected to be found near the very end of other knobs (right before targets section starts).