Differential D27348 Diff 79922 usr.sbin/bhyve/smbiostbl.c

Changeset View

Standalone View

usr.sbin/bhyve/smbiostbl.c

Show First 20 Lines • Show All 751 Lines • ▼ Show 20 Lines	smbios_type19_initializer(struct smbios_structure *template_entry,

if (guest_himem > 0) {		if (guest_himem > 0) {
curaddr = *endaddr;		curaddr = *endaddr;
smbios_generic_initializer(template_entry, template_strings,		smbios_generic_initializer(template_entry, template_strings,
curaddr, endaddr, n, size);		curaddr, endaddr, n, size);
type19 = (struct smbios_table_type19 *)curaddr;		type19 = (struct smbios_table_type19 *)curaddr;
type19->arrayhand = type16_handle;		type19->arrayhand = type16_handle;
type19->xsaddr = 4*GB;		type19->xsaddr = 4*GB;
type19->xeaddr = guest_himem;		type19->xeaddr = guest_himem + (4*GB);
		rgrimesUnsubmitted Done Inline Actions Isnt this tied to the xsaddr setting in the preceding line, such that this should more correctly be written: type19->xeaddr = guest_himem + type19->xsaddr; rgrimes: Isnt this tied to the xsaddr setting in the preceding line, such that this should more…
		jhbUnsubmitted Done Inline Actions Perhaps, though that's relatively minor (and it won't ever move). The other nitpick one could observe is to perhaps order it as 'start + size' instead of 'size + start', i.e. `xsaddr + guest_himem`, but any of the variants is fine with me TBH. jhb: Perhaps, though that's relatively minor (and it won't ever move). The other nitpick one could…
		bcranAuthorUnsubmitted Done Inline Actions I agree, @rgrimes - I'll fix it to be `type19->xsaddr + guest_himem;` bcran: I agree, @rgrimes - I'll fix it to be `type19->xsaddr + guest_himem;`
}		}

return (0);		return (0);
}		}

static void		static void
smbios_ep_initializer(struct smbios_entry_point *smbios_ep, uint32_t staddr)		smbios_ep_initializer(struct smbios_entry_point *smbios_ep, uint32_t staddr)
{		{
▲ Show 20 Lines • Show All 94 Lines • Show Last 20 Lines