Page MenuHomeFreeBSD
Differential D3948 Diff 9535 net-mgmt/ccnet/Makefile

Changeset View

Standalone View

View Options

net-mgmt/ccnet/Makefile

# $FreeBSD$ # $FreeBSD$
PORTNAME= ccnet PORTNAME= ccnet
PORTVERSION= 4.0.6 PORTVERSION= 4.4.3
DISTVERSIONPREFIX= v DISTVERSIONPREFIX= v
DISTVERSIONSUFFIX= -server DISTVERSIONSUFFIX= -server
PORTREVISION= 6
CATEGORIES= net-mgmt devel CATEGORIES= net-mgmt devel
MAINTAINER= yan_jingfeng@yahoo.com MAINTAINER= yan_jingfeng@yahoo.com
COMMENT= Framework for writing networked applications COMMENT= Framework for writing networked applications
LICENSE= GPLv3 LICENSE= GPLv3
LICENSE_FILE= ${WRKSRC}/LICENCE.txt
koobsUnsubmitted
Done
Inline Actions

LICENSE_FILE?

koobs: LICENSE_FILE?
BUILD_DEPENDS= valac:${PORTSDIR}/lang/vala BUILD_DEPENDS= valac:${PORTSDIR}/lang/vala
LIB_DEPENDS= libsearpc.so:${PORTSDIR}/devel/libsearpc \ LIB_DEPENDS= libsearpc.so:${PORTSDIR}/devel/libsearpc \
libglib-2.0.so:${PORTSDIR}/devel/glib20 \ libglib-2.0.so:${PORTSDIR}/devel/glib20 \
libgobject-2.0.so:${PORTSDIR}/devel/glib20 \ libgobject-2.0.so:${PORTSDIR}/devel/glib20 \
libsqlite3.so:${PORTSDIR}/databases/sqlite3 \ libsqlite3.so:${PORTSDIR}/databases/sqlite3 \
libzdb.so:${PORTSDIR}/databases/libzdb \ libzdb.so:${PORTSDIR}/databases/libzdb \
libuuid.so:${PORTSDIR}/misc/e2fsprogs-libuuid \ libuuid.so:${PORTSDIR}/misc/e2fsprogs-libuuid \
libevent.so:${PORTSDIR}/devel/libevent2 \ libevent.so:${PORTSDIR}/devel/libevent2 \
libjansson.so:${PORTSDIR}/devel/jansson \ libjansson.so:${PORTSDIR}/devel/jansson \
libldap.so:${PORTSDIR}/net/openldap24-client libldap.so:${PORTSDIR}/net/openldap24-client
USE_GITHUB= yes USE_GITHUB= yes
GH_ACCOUNT= haiwen GH_ACCOUNT= haiwen
USES= autoreconf libtool pkgconfig pathfix python:2 USES= autoreconf libtool localbase pathfix pkgconfig python:-2.7 \
koobsUnsubmitted
Done
Inline Actions
  • Group your USE/USES together
  • Do you intend for this port to depend on the lang/python2 port (the one that provides the python2 symlink, or just say it only supports 2.x? If the latter, use USES=python:-2.7
koobs: * Group your USE/USES together * Do you intend for this port to depend on the lang/python2 port…
PATHFIX_MAKEFILEIN= Makefile.am shebangfix
USE_LDCONFIG= yes USE_LDCONFIG= yes
USE_OPENSSL= yes
SHEBANG_FILES= tools/*.py
PATHFIX_MAKEFILEIN= Makefile.am
koobsUnsubmitted
Done
Inline Actions

Group USE/USES together

koobs: Group USE/USES together
CPPFLAGS+= -I${LOCALBASE}/include -I${LOCALBASE}/include/event2
LDFLAGS+= -L${LOCALBASE}/lib -L${LOCALBASE}/lib/event2
CONFIGURE_ENV= SSL_CFLAGS="${OPENSSLINC}" SSL_LIBS="-L${OPENSSLLIB} -lssl -lcrypto" CONFIGURE_ENV= SSL_CFLAGS="${OPENSSLINC}" SSL_LIBS="-L${OPENSSLLIB} -lssl -lcrypto"
koobsUnsubmitted
Done
Inline Actions

I'm not a fan of global scoped *FLAGS (-I${LOCALBASE}/include). If you can de-scope these by using a specific configure or Makefile argument/envvar, then do so.

If it's absolutely, USES=localbase does this for {CPP,C,CXX,LD}FLAGS.

koobs: I'm not a fan of global scoped *FLAGS (-I${LOCALBASE}/include). If you can de-scope these by…
koobsUnsubmitted
Done
Inline Actions

I'm not a fan of global scoped *FLAGS (-L${LOCALBASE}/lib). If you can de-scope these by using a specific configure or Makefile argument/envvar, then do so.

If it's absolutely, USES=localbase does this for {CPP,C,CXX,LD}FLAGS.

koobs: I'm not a fan of global scoped *FLAGS (-L${LOCALBASE}/lib). If you can de-scope these by using…
GNU_CONFIGURE= yes GNU_CONFIGURE= yes
CONFIGURE_ARGS+=--enable-server --enable-ldap CONFIGURE_ARGS+= --enable-server --enable-ldap
koobsUnsubmitted
Done
Inline Actions

Indentation

koobs: Indentation
INSTALL_TARGET= install-strip INSTALL_TARGET= install-strip
USE_OPENSSL= yes
HAIWENDIR= www/haiwen HAIWENDIR= www/haiwen
koobsUnsubmitted
Done
Inline Actions

Group USE/USES together

koobs: Group USE/USES together
SEAFILE_SERVER= ${HAIWENDIR}/seafile-server SEAFILE_SERVER= ${HAIWENDIR}/seafile-server
SEABIN= ${SEAFILE_SERVER}/seafile/bin SEABIN= ${SEAFILE_SERVER}/seafile/bin
SEALIB= ${SEAFILE_SERVER}/seafile/lib SEALIB= ${SEAFILE_SERVER}/seafile/lib
SEAFILE_USERNAME?= www SEAFILE_USERNAME?= www
SEAFILE_GROUPNAME?= ${SEAFILE_USERNAME} SEAFILE_GROUPNAME?= ${SEAFILE_USERNAME}
PLIST_SUB= SEAFILE_USERNAME=${SEAFILE_USERNAME} \ PLIST_SUB= SEAFILE_USERNAME=${SEAFILE_USERNAME} \
SEAFILE_GROUPNAME=${SEAFILE_GROUPNAME} \ SEAFILE_GROUPNAME=${SEAFILE_GROUPNAME} \
SEAFILE_SERVER=${SEAFILE_SERVER} \ SEAFILE_SERVER=${SEAFILE_SERVER} \
HAIWENDIR=${HAIWENDIR} HAIWENDIR=${HAIWENDIR}
.include <bsd.port.options.mk> .include <bsd.port.options.mk>
.if ${OPSYS} == FreeBSD && ${OSVERSION} < 1000000 .if ${OPSYS} == FreeBSD && ${OSVERSION} < 1000000
koobsUnsubmitted
Not Done
Inline Actions

I'd like to see a comment here (at some point) from the maintainer as to why this is necessary, and/or what needs to be done (TODO) to remove it.

koobs: I'd like to see a comment here (at some point) from the maintainer as to why this is necessary…
WITH_OPENSSL_PORT= yes WITH_OPENSSL_PORT= yes
.endif .endif
post-install: post-install:
@${MKDIR} ${STAGEDIR}${PREFIX}/${SEABIN} ${STAGEDIR}${PREFIX}/${SEALIB} @${MKDIR} ${STAGEDIR}${PREFIX}/${SEABIN} ${STAGEDIR}${PREFIX}/${SEALIB}
${INSTALL_PROGRAM} ${STAGEDIR}${PREFIX}/bin/ccnet-init ${STAGEDIR}${PREFIX}/${SEABIN} ${INSTALL_PROGRAM} ${STAGEDIR}${PREFIX}/bin/ccnet-init ${STAGEDIR}${PREFIX}/${SEABIN}
${INSTALL_PROGRAM} ${STAGEDIR}${PREFIX}/bin/ccnet-server ${STAGEDIR}${PREFIX}/${SEABIN} ${INSTALL_PROGRAM} ${STAGEDIR}${PREFIX}/bin/ccnet-server ${STAGEDIR}${PREFIX}/${SEABIN}
${INSTALL_PROGRAM} ${STAGEDIR}${PREFIX}/bin/ccnet-servtool ${STAGEDIR}${PREFIX}/${SEABIN} ${INSTALL_PROGRAM} ${STAGEDIR}${PREFIX}/bin/ccnet-servtool ${STAGEDIR}${PREFIX}/${SEABIN}
${RM} ${STAGEDIR}${PREFIX}/bin/ccnet-init \ ${RM} ${STAGEDIR}${PREFIX}/bin/ccnet-init \
${STAGEDIR}${PREFIX}/bin/ccnet-server \ ${STAGEDIR}${PREFIX}/bin/ccnet-server \
${STAGEDIR}${PREFIX}/bin/ccnet-servtool ${STAGEDIR}${PREFIX}/bin/ccnet-servtool
(cd ${STAGEDIR}${PREFIX}/lib && \ (cd ${STAGEDIR}${PREFIX}/lib && \
${COPYTREE_SHARE} ${PYTHON_VERSION} ${STAGEDIR}${PREFIX}/${SEALIB}) ${COPYTREE_SHARE} ${PYTHON_VERSION} ${STAGEDIR}${PREFIX}/${SEALIB})
@${RM} -rf ${STAGEDIR}${PREFIX}/lib/${PYTHON_VERSION} @${RM} -rf ${STAGEDIR}${PREFIX}/lib/${PYTHON_VERSION}
.include <bsd.port.mk> .include <bsd.port.mk>