Changeset View
Changeset View
Standalone View
Standalone View
Mk/Scripts/qa.sh
Show First 20 Lines • Show All 1,006 Lines • ▼ Show 20 Lines | |||||||||
reinplace() | reinplace() | ||||||||
{ | { | ||||||||
if [ -f ${REWARNFILE} ]; then | if [ -f ${REWARNFILE} ]; then | ||||||||
warn "Possible REINPLACE_CMD issues" | warn "Possible REINPLACE_CMD issues" | ||||||||
cat ${REWARNFILE} | cat ${REWARNFILE} | ||||||||
fi | fi | ||||||||
} | } | ||||||||
checks="shebang symlinks paths stripped desktopfileutils sharedmimeinfo" | CHECKS="shebang symlinks paths stripped desktopfileutils sharedmimeinfo suidfiles libtool libperl prefixvar baselibs terminfo proxydeps sonames | ||||||||
mat: Why rename checks to CHECKS, and why make it a multiline variable? | |||||||||
dvlAuthorUnsubmitted Done Inline Actions
dvl: - CHECKS is habit; it is what I do at home
- multi-line was to wrap at 80 characters | |||||||||
checks="$checks suidfiles libtool libperl prefixvar baselibs terminfo" | perlcore no_arch gemdeps gemfiledeps flavors license depends_blacklist pkgmessage reinplace" | ||||||||
Done Inline Actions
We try to move away from having magic strings, I would rather it be something like this. mat: We try to move away from having magic strings, I would rather it be something like this. | |||||||||
checks="$checks proxydeps sonames perlcore no_arch gemdeps gemfiledeps flavors" | |||||||||
checks="$checks license depends_blacklist pkgmessage reinplace" | for check in ${CHECKS}; do | ||||||||
dvlAuthorUnsubmitted Done Inline ActionsI tried to avoid CHECKS= and keep all the options in the if, but
dvl: I tried to avoid CHECKS= and keep all the options in the if, but
* that doesn't work, you get… | |||||||||
eval check_test="\$IGNORE_QA_$check" | |||||||||
if [ -z ${check_test} ]; then | |||||||||
checks="$checks $check" | |||||||||
else | |||||||||
warn "Ignoring $check QA test" | |||||||||
dvlAuthorUnsubmitted Done Inline ActionsAny IGNORE option gets flagged in the output dvl: Any IGNORE option gets flagged in the output | |||||||||
fi | |||||||||
done | |||||||||
ret=0 | ret=0 | ||||||||
cd ${STAGEDIR} || exit 1 | cd ${STAGEDIR} || exit 1 | ||||||||
for check in ${checks}; do | for check in ${checks}; do | ||||||||
Done Inline ActionsCan you please put back the check variable definition as it was before? mat: Can you please put back the check variable definition as it was before? | |||||||||
${check} || ret=1 | ${check} || ret=1 | ||||||||
done | done | ||||||||
Not Done Inline ActionsYou need to quote the variable in there. mat: You need to quote the variable in there. | |||||||||
Done Inline ActionsDo you mean: [ -z "${check_test}" ] dvl: Do you mean: [ -z "${check_test}" ]
| |||||||||
Done Inline ActionsYes, only one variable in the line I quoted. mat: Yes, only one variable in the line I quoted. | |||||||||
exit ${ret} | exit ${ret} |
Why rename checks to CHECKS, and why make it a multiline variable?