Changeset View
Changeset View
Standalone View
Standalone View
devel/kf5-ktexteditor/Makefile
| Show All 11 Lines | |||||
| USES= cmake compiler:c++11-lib gettext kde:5 pkgconfig qt:5 tar:xz | USES= cmake compiler:c++11-lib gettext kde:5 pkgconfig qt:5 tar:xz | ||||
| USE_KDE= archive auth codecs completion config configwidgets \ | USE_KDE= archive auth codecs completion config configwidgets \ | ||||
| coreaddons ecm guiaddons i18n iconthemes itemviews \ | coreaddons ecm guiaddons i18n iconthemes itemviews \ | ||||
| jobwidgets kio parts service sonnet syntaxhighlighting \ | jobwidgets kio parts service sonnet syntaxhighlighting \ | ||||
| textwidgets widgetsaddons xmlgui | textwidgets widgetsaddons xmlgui | ||||
| USE_QT= buildtools_build concurrent core dbus declarative gui \ | USE_QT= buildtools_build concurrent core dbus declarative gui \ | ||||
| network printsupport qmake_build script widgets xml xmlpatterns | network printsupport qmake_build script widgets xml xmlpatterns | ||||
| OPTIONS_DEFINE= EDITORCONFIG | |||||
| OPTIONS_DEFAULT= ${OPTIONS_DEFINE} | |||||
mat: It is better to define OPTIONS_DEFAULT and OPTIONS_DEFINE statically. | |||||
| EDITORCONFIG_DESC= Support .editorconfig | |||||
matUnsubmitted Not Done Inline ActionsSupport how? Editing it? Parsing it? Displaying it? a *_DESC must describe what the option is doing, "support" is so vague, it is absolutely useless. (Yes, I know, 99.9% of options descriptions are useless.) mat: Support how? Editing it? Parsing it? Displaying it?
a `*_DESC` must **describe** what the… | |||||
| EDITORCONFIG_LIB_DEPENDS= libeditorconfig.so:editors/editorconfig-core-c | |||||
| .include <bsd.port.mk> | .include <bsd.port.mk> | ||||
It is better to define OPTIONS_DEFAULT and OPTIONS_DEFINE statically.