Enable .editorconfig support in devel/kf5-ktexteditor

[tcberner]

Summary

Most Linuxes have .editorconfig enabled in KTextEditor (hence kate,
kdevelop, ...) and editorconfig.org lists kate as supported.
But to get that, we need to actually enable it at build-time,
by linking against libeditorconfig.

Adds an OPTION, on-by-default.

Test Plan

This should go out with the next KF5 update (which will force updates to
all the editors anyway).

[tcberner]

Why make it an option? Is there any benefit in not having it?

[mat]

You are missing a PORTREVISION bump.

devel/kf5-ktexteditor/Makefile

21

It is better to define OPTIONS_DEFAULT and OPTIONS_DEFINE statically.

23

Support how? Editing it? Parsing it? Displaying it?

a *_DESC must describe what the option is doing, "support" is so vague, it is absolutely useless. (Yes, I know, 99.9% of options descriptions are useless.)

[tcberner]

Also if it remains an option there needs to be an option toggle to cmake.. Or is it not linking actually?

[adridg]

As Tobias points out, it's probably better to avoid the option and always include it. Then we don't need to worry about an option description :)

When the editorconfig libraries are present on the system at cmake-time, they will be used and linked into the ktexteditor libraries. If we make it an option, then we also need to support the case where the option is off, but the libraries are installed; things get complicated for basic functionality that, IMO, should always be there: the presence of an .editorconfig file influences the editor settings underneath the directory holding the .editorconfig file.

[adridg]

So, file under:

Let's pick this up in the next frameworks update

[tcberner]

I'll add it to https://github.com/freebsd/freebsd-ports-kde/tree/kf5-5.67 for tomorrow's exp-run

[tcberner]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244015