Changeset View
Changeset View
Standalone View
Standalone View
net/pathneck/Makefile
# Created by: Babak Farrokhi <babak@farrokhi.net> | # Created by: Babak Farrokhi <babak@farrokhi.net> | ||||
# $FreeBSD$ | # $FreeBSD$ | ||||
PORTNAME= pathneck | PORTNAME= pathneck | ||||
PORTVERSION= 1.3 | PORTVERSION= 1.3 | ||||
CATEGORIES= net | CATEGORIES= net | ||||
MASTER_SITES= http://www.cs.cmu.edu/~hnn/pathneck/ \ | MASTER_SITES= http://www.cs.cmu.edu/~hnn/pathneck/ \ | ||||
http://gs274.sp.cs.cmu.edu/www/pathneck/ | http://gs274.sp.cs.cmu.edu/www/pathneck/ | ||||
MAINTAINER= farrokhi@FreeBSD.org | MAINTAINER= farrokhi@FreeBSD.org | ||||
COMMENT= Active network path probing tool | COMMENT= Active network path probing tool | ||||
LICENSE= GPLv2 | |||||
LICENSE_FILE= ${WRKSRC}/COPYING | |||||
MAKEFILE= Makefile.bsd | |||||
danfe: `MAKEFILE` above `USES` still looks a bit weird, do you mind putting it below? (Flipping two… | |||||
USES= tar:tgz | |||||
PLIST_FILES= sbin/pathneck \ | PLIST_FILES= sbin/pathneck \ | ||||
sbin/get-choke | sbin/get-choke | ||||
PORTDOCS= COPYING ChangeLog README | PORTDOCS= COPYING ChangeLog README | ||||
danfeUnsubmitted Done Inline ActionsOnce you've added COPYING as LICENSE_FILE, it should be removed from PORTDOCS, otherwise it will be installed twice which is probably not what you want. danfe: Once you've added `COPYING` as `LICENSE_FILE`, it should be removed from `PORTDOCS`, otherwise… | |||||
MAKEFILE= Makefile.bsd | |||||
USES= tar:tgz | |||||
OPTIONS_DEFINE= DOCS | OPTIONS_DEFINE= DOCS | ||||
post-patch: | post-patch: | ||||
@${REINPLACE_CMD} -e 's,^CC .=,CC ?=,' \ | @${REINPLACE_CMD} -e 's,^CC .=,CC ?=,' \ | ||||
-e 's,^CFLAGS .=,CFLAGS +=,' \ | -e 's,^CFLAGS .=,CFLAGS +=,' \ | ||||
${WRKSRC}/Makefile.bsd | ${WRKSRC}/Makefile.bsd | ||||
danfeUnsubmitted Not Done Inline ActionsYou might want to check if Makefile.bsd patching is really needed; often (not always! I see += there which can make a difference) it's better to simply pass CC and CFLAGS via MAKE_ARGS. danfe: You might want to check if `Makefile.bsd` patching is really needed; often (not always! I see… | |||||
farrokhiAuthorUnsubmitted Not Done Inline ActionsOverriding CFLAGS when calling make breaks the build. I believe it should be patched. However CC can be safely passed via MAKE_ARGS. farrokhi: Overriding `CFLAGS` when calling `make` breaks the build. I believe it should be patched. | |||||
do-install: | do-install: | ||||
${INSTALL_PROGRAM} ${WRKSRC}/pathneck ${STAGEDIR}${PREFIX}/sbin/pathneck | ${INSTALL_PROGRAM} ${WRKSRC}/pathneck ${STAGEDIR}${PREFIX}/sbin | ||||
${INSTALL_PROGRAM} ${WRKSRC}/get-choke \ | ${INSTALL_PROGRAM} ${WRKSRC}/get-choke ${STAGEDIR}${PREFIX}/sbin | ||||
${STAGEDIR}${PREFIX}/sbin/get-choke | |||||
do-install-DOCS-on: | do-install-DOCS-on: | ||||
${MKDIR} ${STAGEDIR}${DOCSDIR} | ${MKDIR} ${STAGEDIR}${DOCSDIR} | ||||
.for f in ${PORTDOCS} | .for f in ${PORTDOCS} | ||||
${INSTALL_DATA} ${WRKSRC}/${f} ${STAGEDIR}${DOCSDIR} | ${INSTALL_DATA} ${WRKSRC}/${f} ${STAGEDIR}${DOCSDIR} | ||||
.endfor | .endfor | ||||
.include <bsd.port.mk> | .include <bsd.port.mk> |
MAKEFILE above USES still looks a bit weird, do you mind putting it below? (Flipping two knobs.)