Changeset View
Standalone View
devel/py-pythondialog/Makefile
| # Created by: ijliao | |||||
| # $FreeBSD$ | # $FreeBSD$ | ||||
| PORTNAME= dialog | PORTNAME= pythondialog | ||||
| PORTVERSION= 2.7 | PORTVERSION= 3.4.0 | ||||
| PORTREVISION= 4 | |||||
| CATEGORIES= devel python | CATEGORIES= devel python | ||||
| MASTER_SITES= SF/python${PORTNAME}/python${PORTNAME}/${PORTVERSION} | MASTER_SITES= SF \ | ||||
| LOCAL/jkim | |||||
| PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} | PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} | ||||
koobs: Ports SHOULD use MASTER_SITES=CHEESESHOP if a Python package is registered on PyPI, unless… | |||||
Done Inline ActionsOkay. jkim: Okay. | |||||
| DISTNAME= pythondialog-${PORTVERSION} | DISTNAME= python${PYTHON_MAJOR_VER}-${PORTNAME}-${PORTVERSION} | ||||
Not Done Inline ActionsThis (likely) shouldnt be necessary after updating to use PyPI as MASTER_SITES koobs: This (likely) shouldnt be necessary after updating to use PyPI as MASTER_SITES | |||||
Done Inline ActionsWell, pythondialog has two projects unfortunately. https://pypi.org/project/pythondialog Unless you prefer two separate projects, it is necessary. jkim: Well, pythondialog has two projects unfortunately.
https://pypi.org/project/pythondialog
https… | |||||
Not Done Inline ActionsHmm. Still a little confused I can see:
I can't see a package for python3-pythondialog, so how will/does this port work for Python 3 ? koobs: Hmm. Still a little confused
I can see:
* python2-pythondialog package, which is Python >=3… | |||||
Done Inline ActionsActually, it's the opposite. https://pypi.org/project/pythondialog/ Requirements
https://pypi.org/project/python2-pythondialog/ Requirements
In other words,
jkim: Actually, it's the opposite.
https://pypi.org/project/pythondialog/
**Requirements**
- As of… | |||||
| MAINTAINER= mek@mek.uz.ua | MAINTAINER= jkim@FreeBSD.org | ||||
| COMMENT= Python interface to dialog(3) | COMMENT= Python interface to dialog(3) | ||||
| LICENSE= LGPL20 | LICENSE= LGPL21+ | ||||
| RUN_DEPENDS= cdialog:devel/cdialog | RUN_DEPENDS= cdialog:devel/cdialog | ||||
| USES= python:2.7 tar:bzip2 | USES= python tar:bz2 | ||||
| USE_PYTHON= distutils | USE_PYTHON= autoplist concurrent distutils pythonprefix | ||||
Not Done Inline Actionssetup.py contains python_requires=">=3" which means it (apparently) only supports Python 3.x "Python ports MUST declare USES=python :<version-spec> as completely and accurately as possible, without being incorrect, given existing syntax constraints." [1] [1] https://wiki.freebsd.org/Python/PortsPolicy#USES.3Dpython koobs: setup.py contains `python_requires=">=3"` which means it (apparently) only supports Python 3.x… | |||||
Done Inline ActionsOkay. jkim: Okay. | |||||
Not Done Inline ActionsWhat is/was pythonprefix required for? The vast majority of ports don't require this, so it would be informative to know the reason koobs: What is/was `pythonprefix` required for? The vast majority of ports don't require this, so it… | |||||
Done Inline ActionsOops, it was copied from an old port. jkim: Oops, it was copied from an old port. | |||||
| PYDISTUTILS_PKGNAME= pythondialog | |||||
| EXAMPLESDIR= ${PREFIX}/share/examples/py-dialog | CONFLICTS= ${PYTHON_PKGNAMEPREFIX}dialog${PYTHON_MAJOR_VER:S/^2//} | ||||
Not Done Inline ActionsWhat port/package does this conflict refer to? If there is indeed a conflicting port/package, it probably only CONFLICTS_INSTALL (CONFLICTS means conflicts at install *and* build time) koobs: What port/package does this conflict refer to?
If there is indeed a conflicting port/package… | |||||
Done Inline ActionsBasically, this port replaces devel/py-dialog and devel/py-dialog3. Don't we have to check the old packages? Anyway, you're right. CONFLICTS_INSTALL is better. jkim: Basically, this port replaces devel/py-dialog and devel/py-dialog3. Don't we have to check the… | |||||
| post-install: | PORTEXAMPLES= * | ||||
| ${MKDIR} ${STAGEDIR}${EXAMPLESDIR} | REINPLACE_ARGS= -i "" | ||||
| ${INSTALL_DATA} ${WRKSRC}/demo.py ${STAGEDIR}${EXAMPLESDIR} | WRKSRC= "${WRKDIR}/${DISTNAME:C/^python3-//}" | ||||
Not Done Inline ActionsThis shouldnt be necessary after updating to use PyPI as MASTER_SITES koobs: This shouldnt be necessary after updating to use PyPI as MASTER_SITES | |||||
Done Inline ActionsYes, you're right. jkim: Yes, you're right. | |||||
| OPTIONS_DEFINE= EXAMPLES | |||||
| post-patch: | |||||
| ${FIND} ${WRKSRC} -type f | \ | |||||
| ${XARGS} ${REINPLACE_CMD} -e 's|dialog="dialog"|dialog="cdialog"|g' | |||||
Not Done Inline ActionsWhat is this block needed for? koobs: What is this block needed for? | |||||
Done Inline ActionsThis port uses cdialog from devel/cdialog instead of dialog(1) because our fork is incompatible. jkim: This port uses cdialog from devel/cdialog instead of dialog(1) because our fork is incompatible. | |||||
Not Done Inline ActionsAhh thanks, would be great to have a comment above this block for our future selves koobs: Ahh thanks, would be great to have a comment above this block for our future selves | |||||
| post-install-EXAMPLES-on: | |||||
| @${MKDIR} ${STAGEDIR}${EXAMPLESDIR} | |||||
| cd ${WRKSRC}/examples/ && \ | |||||
| ${COPYTREE_SHARE} . ${STAGEDIR}${EXAMPLESDIR} "! -name *\.bak" | |||||
| .include <bsd.port.mk> | .include <bsd.port.mk> | ||||
Ports SHOULD use MASTER_SITES=CHEESESHOP if a Python package is registered on PyPI, unless there is a compelling (temporary) case not to. [1]
https://wiki.freebsd.org/Python/PortsPolicy#MASTER_SITES