Page MenuHomeFreeBSD
Differential D21018 Diff 60027 tests/sys/opencrypto/runtests.sh

Changeset View

Standalone View

View Options

tests/sys/opencrypto/runtests.sh

Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Linescleanup_tests()
# Unload modules in reverse order # Unload modules in reverse order
for loaded_module in $(echo $loaded_modules | tr ' ' '\n' | sort -r); do for loaded_module in $(echo $loaded_modules | tr ' ' '\n' | sort -r); do
kldunload $loaded_module kldunload $loaded_module
done done
} }
trap cleanup_tests EXIT INT TERM trap cleanup_tests EXIT INT TERM
for required_module in nexus/aesni cryptodev; do cpu_type="$(uname -p)"
cpu_module=
case “${cpu_type}” in
aarch64)
ngieUnsubmitted
Done
Inline Actions

Please use a switch statement here, e.g.,

case “${cpu_type}” in
aarch64)
    cpu_module=...
    ;;
amd64|i386)
    cpu_module=...
    ;;
esac

The above change would break some testing on i386.

PS please pardon my editing. I’m submitting the comment via my iPhone).

ngie: Please use a switch statement here, e.g., case “${cpu_type}” in aarch64)…
val_packett.coolAuthorUnsubmitted
Done
Inline Actions

Of course Intel added AES-NI to the 32-bit mode, why did I assume that all new features were restricted to 64-bit.. Sorry :D

Updated the patch.

val_packett.cool: Of course Intel added AES-NI to the 32-bit mode, why did I assume that all new features were…
cpu_module=nexus/armv8crypto
;;
amd64|i386)
cpu_module=nexus/aesni
;;
esac
for required_module in $cpu_module cryptodev; do
if ! kldstat -q -m $required_module; then if ! kldstat -q -m $required_module; then
module_to_load=${required_module#nexus/} module_to_load=${required_module#nexus/}
if ! kldload ${module_to_load}; then if ! kldload ${module_to_load}; then
echo "1..0 # SKIP: could not load ${module_to_load}" echo "1..0 # SKIP: could not load ${module_to_load}"
exit 0 exit 0
fi fi
loaded_modules="$loaded_modules $required_module" loaded_modules="$loaded_modules $required_module"
fi fi
Show All 18 Lines