Changeset View
Standalone View
net/py-python-bitcoinrpc/Makefile
- This file was added.
| Property | Old Value | New Value |
|---|---|---|
| svn:eol-style | null | native \ No newline at end of property |
| svn:keywords | null | FreeBSD=%H \ No newline at end of property |
| svn:mime-type | null | text/plain \ No newline at end of property |
| # Created by: loader <loader@FreeBSD.org> | |||||
| # $FreeBSD$ | |||||
| PORTNAME= python-bitcoinrpc | |||||
| PORTVERSION= 0.3 | |||||
koobs: Upstream needs to update their PyPi version :)
Also their
```
__version__
```
string:
https… | |||||
| DISTVERSIONPREFIX= v | |||||
Not Done Inline ActionsI would use 0.3.0.<date> to mean, v.0.3.0 + commits up to <datestamp> This way when the next version is released (0.3.1, 0.4.0, etc), the port wont require a PORTEPOCH bump. koobs: I would use 0.3.0.<date> to mean, v.0.3.0 + commits up to <datestamp>
This way when the next… | |||||
Not Done Inline Actionsthank you for your quick reply, I will upload another patch. loader: thank you for your quick reply, I will upload another patch. | |||||
| CATEGORIES= net python | |||||
Not Done Inline ActionsSure. submitted it to upstream. https://github.com/ubldr/python-bitcoinrpc/commit/2cf384a6782a419b903225c7390ee6d90c09c555 loader: Sure. submitted it to upstream. https://github.com/ubldr/python… | |||||
Not Done Inline Actionsoops, the URL should be https://github.com/jgarzik/python-bitcoinrpc/pull/53 loader: oops, the URL should be https://github.com/jgarzik/python-bitcoinrpc/pull/53 | |||||
koobsUnsubmitted Not Done Inline ActionsMaybe finance as secondary (leaving python as tertiary virtual)? What secondary categories are other bitcoin ports in? koobs: Maybe finance as secondary (leaving python as tertiary virtual)?
What secondary categories are… | |||||
| PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} | |||||
Not Done Inline ActionsThanks @koobs loader: Thanks @koobs
added finance as secondary category | |||||
| MAINTAINER= loader@FreeBSD.org | |||||
| COMMENT= Enhanced version of python-jsonrpc for use with Bitcoin | |||||
| LICENSE= LGPL20 | |||||
koobsUnsubmitted Not Done Inline ActionsUpstream doesn't have a LICENSE_FILE, so ask them to add one :) I added comment here: https://github.com/jgarzik/python-bitcoinrpc/issues/42#issuecomment-128411210 Not a commit blocker. koobs: Upstream doesn't have a LICENSE_FILE, so ask them to add one :)
I added comment here: https… | |||||
| USE_GITHUB= yes | |||||
| GH_ACCOUNT= jgarzik | |||||
| USES= python | |||||
| USE_PYTHON= autoplist distutils | |||||
| post-patch: | |||||
| @${TOUCH} ${WRKSRC}/bitcoinrpc/__init__.py | |||||
koobsUnsubmitted Not Done Inline ActionsRationale? v0.3 doesnt appear to have the bitcoinrpc directory in the tarball: https://github.com/jgarzik/python-bitcoinrpc/tree/v0.3/ I'd either:
I know last revision I said that backporting changes is often the best thing to do. In this case its a substantial changeset, so to save you time, use the hash you want, but just be 'smart' about correctly 'naming' the version so users aren't confused :) And ask the author for a new tag/release :) koobs: Rationale?
v0.3 doesnt appear to have the bitcoinrpc directory in the tarball:
https://github. | |||||
Not Done Inline Actionsplease let me know if it's okay to use the last commit date from upstream as the PORTVERSION BTW. Is there any best practices for creating a patch with an empty__init__.py? loader: please let me know if it's okay to use the last commit date from upstream as the PORTVERSION… | |||||
Not Done Inline ActionsI can't think of a better way than touch(8) if our patch can't do it koobs: I can't think of a better way than touch(8) if our patch can't do it | |||||
Not Done Inline Actionsokay, thank you. loader: okay, thank you. | |||||
| .include <bsd.port.mk> | |||||
Upstream needs to update their PyPi version :)
Also their
string:
https://github.com/jgarzik/python-bitcoinrpc/blob/master/setup.py#L6
Note: This comment is not a commit blocker.