Page MenuHomeFreeBSD
Differential D17285 Diff 55402 www/p5-RT-Extension-CommandByMail/Makefile

Changeset View

Standalone View

View Options

www/p5-RT-Extension-CommandByMail/Makefile

# Created by: Michael Schout <mschout@gkg.net> # Created by: Michael Schout <mschout@gkg.net>
# $FreeBSD$ # $FreeBSD$
PORTNAME= RT-Extension-CommandByMail PORTNAME= RT-Extension-CommandByMail
PORTVERSION= 3.00 PORTVERSION= 3.00
PORTREVISION= 1
CATEGORIES= www perl5 CATEGORIES= www perl5
MASTER_SITES= CPAN MASTER_SITES= CPAN
PKGNAMEPREFIX= p5-
MAINTAINER= sysadmin@gkg.net MAINTAINER= sysadmin@gkg.net
COMMENT= RT Extension to change ticket metadata via email COMMENT= RT Extension to change ticket metadata via email
LICENSE= GPLv2 LICENSE= GPLv2
OPTIONS_SINGLE= RTVERSION
OPTIONS_SINGLE_RTVERSION= RT40 RT42 RT44
RT40_DESC= Install for rt-4.0.x (www/rt40)
RT42_DESC= Install for rt-4.2.x (www/rt42)
RT44_DESC= Install for rt-4.4.x (www/rt44)
OPTIONS_DEFAULT= RT44
.include <bsd.port.options.mk>
.for opt in ${OPTIONS_SINGLE_RTVERSION}
.if ${PORT_OPTIONS:M${opt}}
RT_VER= ${opt:S/RT//}
.endif
.endfor
BUILD_DEPENDS= ${LOCALBASE}/bin/rt:www/rt${RT_VER} BUILD_DEPENDS= ${LOCALBASE}/bin/rt:www/rt${RT_VER}
RUN_DEPENDS= ${LOCALBASE}/bin/rt:www/rt${RT_VER} RUN_DEPENDS= ${LOCALBASE}/bin/rt:www/rt${RT_VER}
NO_ARCH= yes FLAVOR?= ${FLAVORS:[1]}
FLAVORS= rt44 rt42
rt42_PKGNAMEPREFIX= p5-RT42-
matUnsubmitted
Done
Inline Actions

So, this port really conflicts with the rt44 port? Should it not be p5-RT-Extension-CommandByMail-rt44?

mat: So, this port really conflicts with the rt44 port? Should it not be `p5-RT-Extension…
matthewAuthorUnsubmitted
Done
Inline Actions

The rt42 flavoured port should conflict with rt44. I reworked this to use a PKGNAMEPREFIX as that seems to be the convention for add-on modules, rather than stand-alone applications.

matthew: The rt42 flavoured port should conflict with rt44. I reworked this to use a PKGNAMEPREFIX as…
rt42_CONFLICTS_INSTALL= rt44
rt44_PKGNAMEPREFIX= p5-RT44-
rt44_CONFLICTS_INSTALL= rt42
matUnsubmitted
Done
Inline Actions

It took me about a few minutes rereading of this line before understanding wtf it was doing.

Adding a a line with:

FLAVOR?=	${FLAVORS:[1]}

Would allow this to be a really more readable ${FLAVOR} == rt42.

mat: It took me about a few minutes rereading of this line before understanding wtf it was doing.
.if ${FLAVOR} == rt44
RT_VER= 44
.elif ${FLAVOR} == rt42
RT_VER= 42
.endif
USES= perl5 USES= perl5
USE_PERL5= configure USE_PERL5= configure
NO_ARCH= yes
PLIST_SUB+= RTHOME=share/rt${RT_VER} PLIST_SUB+= RTHOME=share/rt${RT_VER}
# Note: You can install using an arbitrary $PREFIX but only if it # Note: You can install using an arbitrary $PREFIX but only if it
# matches the $PREFIX used to install www/rt{40,42,44}. Hence ignore # matches the $PREFIX used to install www/rt{42,44}. Hence ignore
# $PREFIX in the environment and inherit settings from RT.pm # $PREFIX in the environment and inherit settings from RT.pm
do-configure: do-configure:
@cd ${CONFIGURE_WRKSRC} && \ @cd ${CONFIGURE_WRKSRC} && \
unset PREFIX && \ unset PREFIX && \
${SETENV} ${CONFIGURE_ENV} ${PERL5} -I${SITE_PERL} ${CONFIGURE_CMD} && \ ${SETENV} ${CONFIGURE_ENV} ${PERL5} -I${SITE_PERL} ${CONFIGURE_CMD} && \
${PERL5} -pi -e 's/ doc_(perl|site|\$$\(INSTALLDIRS\))_install$$//' Makefile ${PERL5} -pi -e 's/ doc_(perl|site|\$$\(INSTALLDIRS\))_install$$//' Makefile
post-configure: post-configure:
Show All 12 Lines