Changeset View
Changeset View
Standalone View
Standalone View
devel/subversion/files/extra-patch-fbsd-template
Show First 20 Lines • Show All 117 Lines • ▼ Show 20 Lines | |||||
+ if (sponsored_by != NULL) | + if (sponsored_by != NULL) | ||||
+ svn_stringbuf_appendcstr(default_msg, sponsored_by); | + svn_stringbuf_appendcstr(default_msg, sponsored_by); | ||||
+ svn_stringbuf_appendcstr(default_msg, APR_EOL_STR); | + svn_stringbuf_appendcstr(default_msg, APR_EOL_STR); | ||||
+ svn_stringbuf_appendcstr(default_msg, "Differential Revision:\t" APR_EOL_STR); | + svn_stringbuf_appendcstr(default_msg, "Differential Revision:\t" APR_EOL_STR); | ||||
svn_stringbuf_appendcstr(default_msg, EDITOR_EOF_PREFIX); | svn_stringbuf_appendcstr(default_msg, EDITOR_EOF_PREFIX); | ||||
- svn_stringbuf_appendcstr(default_msg, APR_EOL_STR APR_EOL_STR); | - svn_stringbuf_appendcstr(default_msg, APR_EOL_STR APR_EOL_STR); | ||||
+ svn_stringbuf_appendcstr(default_msg, APR_EOL_STR); | + svn_stringbuf_appendcstr(default_msg, APR_EOL_STR); | ||||
+ svn_stringbuf_appendcstr(default_msg, "> Description of fields to fill in above: 76 columns --|" APR_EOL_STR); | + svn_stringbuf_appendcstr(default_msg, "> Description of fields to fill in above: 76 columns --|" APR_EOL_STR); | ||||
+ svn_stringbuf_appendcstr(default_msg, "> PR: If and which Problem Report is related." APR_EOL_STR); | + svn_stringbuf_appendcstr(default_msg, "> PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=###" APR_EOL_STR); | ||||
rgrimes: id=nnnn or id=PRnnnn? It is unclear to me if it wants the PR or not, iirc the line for… | |||||
vangyzenAuthorUnsubmitted Done Inline ActionsIn my mind, # means "number". Besides, I imagine the vast majority of people will copy the URL directly from their browser, not copy this example and replace the ###. I think it's fine as-is, and I'd rather not make the line any longer, since it's already more than 80 columns. vangyzen: In my mind, `#` means "number". Besides, I imagine the vast majority of people will copy the… | |||||
rgrimesUnsubmitted Not Done Inline ActionsAcceptable, mark my comments as done. rgrimes: Acceptable, mark my comments as done. | |||||
+ svn_stringbuf_appendcstr(default_msg, "> PR: Add more PR lines as needed." APR_EOL_STR); | |||||
+ svn_stringbuf_appendcstr(default_msg, "> Submitted by: If someone else sent in the change." APR_EOL_STR); | + svn_stringbuf_appendcstr(default_msg, "> Submitted by: If someone else sent in the change." APR_EOL_STR); | ||||
+ svn_stringbuf_appendcstr(default_msg, "> Reported by: If someone else reported the issue." APR_EOL_STR); | + svn_stringbuf_appendcstr(default_msg, "> Reported by: If someone else reported the issue." APR_EOL_STR); | ||||
+ svn_stringbuf_appendcstr(default_msg, "> Reviewed by: If someone else reviewed your modification." APR_EOL_STR); | + svn_stringbuf_appendcstr(default_msg, "> Reviewed by: If someone else reviewed your modification." APR_EOL_STR); | ||||
+ svn_stringbuf_appendcstr(default_msg, "> Approved by: If you needed approval for this commit." APR_EOL_STR); | + svn_stringbuf_appendcstr(default_msg, "> Approved by: If you needed approval for this commit." APR_EOL_STR); | ||||
+ svn_stringbuf_appendcstr(default_msg, "> Obtained from: If the change is from a third party." APR_EOL_STR); | + svn_stringbuf_appendcstr(default_msg, "> Obtained from: If the change is from a third party." APR_EOL_STR); | ||||
+ svn_stringbuf_appendcstr(default_msg, "> MFC after: N [day[s]|week[s]|month[s]]. Request a reminder email." APR_EOL_STR); | + svn_stringbuf_appendcstr(default_msg, "> MFC after: N [day[s]|week[s]|month[s]]. Request a reminder email." APR_EOL_STR); | ||||
+ svn_stringbuf_appendcstr(default_msg, "> MFH: Ports tree branch name. Request approval for merge." APR_EOL_STR); | + svn_stringbuf_appendcstr(default_msg, "> MFH: Ports tree branch name. Request approval for merge." APR_EOL_STR); | ||||
+ svn_stringbuf_appendcstr(default_msg, "> Relnotes: Set to 'yes' for mention in release notes." APR_EOL_STR); | + svn_stringbuf_appendcstr(default_msg, "> Relnotes: Set to 'yes' for mention in release notes." APR_EOL_STR); | ||||
Show All 30 Lines |
id=nnnn or id=PRnnnn? It is unclear to me if it wants the PR or not, iirc the line for phabricator clearly has Dxxxx in it.