Differential D19338 Diff 54332 x11-themes/materia-gtk-theme/Makefile

Changeset View

Standalone View

x11-themes/materia-gtk-theme/Makefile

This file was added.

Property	Old Value	New Value
svn:eol-style	null	native \ No newline at end of property
svn:keywords	null	FreeBSD=%H \ No newline at end of property
svn:mime-type	null	text/plain \ No newline at end of property

				# $FreeBSD$

				PORTNAME= materia-gtk-theme
				DISTVERSIONPREFIX= v
				DISTVERSION= 20190201
				CATEGORIES= x11-themes

				MAINTAINER= tagattie@yandex.com
				COMMENT= Material Design theme for GNOME/GTK+ based desktop environments

				LICENSE= GPLv2
				LICENSE_FILE= ${WRKSRC}/COPYING

				BUILD_DEPENDS= bash:shells/bash
				RUN_DEPENDS= gtk-murrine-engine>0:x11-themes/gtk-murrine-engine \
				gnome-themes-extra>0:x11-themes/gnome-themes-extra

				USES= shebangfix

				USE_GITHUB= yes
				GH_ACCOUNT= nana-4
				GH_PROJECT= materia-theme

				tcbernerUnsubmitted Done Inline Actions ^ why not use that as the portname? tcberner: ^ why not use that as the portname?
				rigolettoAuthorUnsubmitted Done Inline Actions There is a matching Materia theme for KDE. rigoletto: There is a matching Materia theme for KDE.
				tagattie_yandex.comUnsubmitted Not Done Inline Actions I wanted to make it clear that this port is GTK/Gnome theme because there is a materia theme for KDE as well. But I'm indifferent. materia-theme is fine with me. tagattie_yandex.com: I wanted to make it clear that this port is GTK/Gnome theme because there is a materia theme…
				NO_ARCH= yes
				NO_BUILD= yes

				SHEBANG_FILES= install.sh

				do-install:
				${MKDIR} ${STAGEDIR}${PREFIX}/share/themes
				${WRKSRC}/install.sh --dest ${STAGEDIR}${PREFIX}/share/themes

				tagattie_yandex.comUnsubmitted Done Inline Actions Is COPYING necessary here? The license file is installed in "licenses" directory as well. tagattie_yandex.com: Is COPYING necessary here? The license file is installed in "licenses" directory as well.
				rigolettoAuthorUnsubmitted Done Inline Actions Yes. There is no "licenses" directory. If upstream doesn't do it automatically at the install time that will not be in the ${DOCSDIR} if the port doesn't take care of it. :-) rigoletto: Yes. There is no "licenses" directory. If upstream doesn't do it automatically at the install…
				tcbernerUnsubmitted Done Inline Actions ^ why += ? tcberner: ^ why += ?
				rigolettoAuthorUnsubmitted Done Inline Actions There is another was PORTDOCS in the GNOMESHELL OPTION. rigoletto: There is another was PORTDOCS in the GNOMESHELL OPTION.
				post-install:
				${MKDIR} ${STAGEDIR}${DOCSDIR}
				.for d in COPYING README.md src/gnome-shell/README.md
				(cd ${WRKSRC} && \
				${COPYTREE_SHARE} ${d} ${STAGEDIR}${DOCSDIR})
				.endfor
				.for c in COPYING README.md gnome-shell/README.md
				tcbernerUnsubmitted Done Inline Actions ^ there should be some toggle for that for the build system to turn it on and off -- which kind of contradicts `NO_BUILD` -- why do you need it present? tcberner: ^ there should be some toggle for that for the build system to turn it on and off -- which kind…
				rigolettoAuthorUnsubmitted Done Inline Actions Good point! I was sure I've saw on the install file it would detect the gnome-shell presence on-the-fly to add or not the gnome-shell theme; however testing it now I see it is added anyway. So if that was true no-gnome user would need to build half gnome just to get one gtk theme. ^^ rigoletto: Good point! I was sure I've saw on the install file it would detect the gnome-shell presence on…
				${RM} ${STAGEDIR}${PREFIX}/share/themes/*/${c}
				.endfor

				.include <bsd.port.mk>
				tagattie_yandex.comUnsubmitted Done Inline Actions Should this be ${STAGEDIR}${PREFIX}/share/themes ? tagattie_yandex.com: Should this be ${STAGEDIR}${PREFIX}/share/themes ?
				rigolettoAuthorUnsubmitted Done Inline Actions Yes, thank you. rigoletto: Yes, thank you.
				tagattie_yandex.comUnsubmitted Done Inline Actions Removing top-level README.md's seems unnecessary since they are not installed in each theme directory. tagattie_yandex.com: Removing top-level README.md's seems unnecessary since they are not installed in each theme…
				rigolettoAuthorUnsubmitted Done Inline Actions Yes, they are. I got tons of them after running `make makeplist`. ^^ rigoletto: Yes, they are. I got tons of them after running `make makeplist`. ^^
				tagattie_yandex.comUnsubmitted Done Inline Actions PORTDOCS= --> PORTDOCS+= ? tagattie_yandex.com: PORTDOCS= --> PORTDOCS+= ?
				rigolettoAuthorUnsubmitted Done Inline Actions That is in the previous/general one. ^^ rigoletto: That is in the previous/general one. ^^
				matUnsubmitted Done Inline Actions GNOMESHELL_PORTDOCS=.... mat: ``` GNOMESHELL_PORTDOCS=.... ```
				matUnsubmitted Done Inline Actions `PORTDOCS` contains files, why use `COPYTREE_SHARE` and not `INSTALL_DATA`? mat: `PORTDOCS` contains files, why use `COPYTREE_SHARE` and not `INSTALL_DATA`?
				matUnsubmitted Done Inline Actions Don't use both do- and post- for the same stage, put everything in do-install. mat: Don't use both do- and post- for the same stage, put everything in do-install.