Changeset View
Changeset View
Standalone View
Standalone View
lib/libsqlite3/Makefile
Context not available. | |||||
-DHAVE_POSIX_FALLOCATE=1 \ | -DHAVE_POSIX_FALLOCATE=1 \ | ||||
-D_REENTRANT=1 \ | -D_REENTRANT=1 \ | ||||
-DSQLITE_THREADSAFE=1 \ | -DSQLITE_THREADSAFE=1 \ | ||||
-DSQLITE_ENABLE_FTS3 \ | |||||
-DSQLITE_ENABLE_FTS4 \ | |||||
delphij: I only asked for FTS3 being disabled because it's disabled upstream :)
Note that we are not… | |||||
cyAuthorUnsubmitted Done Inline ActionsAgreed, the base sqlite3 should be as minimal as possible, which is why I removed FTS3, FTS4 and RTREE, it's a private library. I'll update this revision to remove RTREE as soon as I get home. The bundled sqlite3 in heimdal has been removed. cy: Agreed, the base sqlite3 should be as minimal as possible, which is why I removed FTS3, FTS4… | |||||
-DSQLITE_ENABLE_RTREE | -DSQLITE_ENABLE_RTREE | ||||
.include <bsd.lib.mk> | .include <bsd.lib.mk> | ||||
Context not available. |
I only asked for FTS3 being disabled because it's disabled upstream :)
Note that we are not using R*Tree extension either in the base system, so if the philosophy is to use a minimized version of SQLite, that should be disabled too. If the goal is to match upstream, then we should enable both FTS4 and FTS5.
Personally, I'm inclined to adopt the minimize approach (remove FTS3, FTS4 and RTREE), though, because this is a private library.
I'd like to see crypto/heimdal/lib/sqlite/ gone in a separate change as well. It's harmless (because it's not connected to build) but might cause confusion.