Changeset View
Standalone View
multimedia/libxine/Makefile
| # Created by: alex | # Created by: alex | ||||
| # $FreeBSD$ | # $FreeBSD$ | ||||
| PORTNAME= xine | PORTNAME= xine | ||||
| PORTVERSION= 1.2.6 | PORTVERSION= 1.2.9 | ||||
| PORTREVISION= 18 | |||||
| CATEGORIES= multimedia ipv6 | CATEGORIES= multimedia ipv6 | ||||
| MASTER_SITES= SF/${PORTNAME}/${PORTNAME}-lib/${PORTVERSION} | MASTER_SITES= SF/${PORTNAME}/${PORTNAME}-lib/${PORTVERSION} | ||||
| PKGNAMEPREFIX= lib | PKGNAMEPREFIX= lib | ||||
| DISTNAME= ${PORTNAME}-lib-${PORTVERSION} | DISTNAME= ${PORTNAME}-lib-${PORTVERSION} | ||||
| MAINTAINER= ports@FreeBSD.org | MAINTAINER= ports@FreeBSD.org | ||||
| COMMENT= Libraries for xine multimedia player | COMMENT= Libraries for xine multimedia player | ||||
| Show All 12 Lines | LIB_DEPENDS= libFLAC.so:audio/flac \ | ||||
| libfame.so:multimedia/libfame \ | libfame.so:multimedia/libfame \ | ||||
| libcdio_paranoia.so:sysutils/libcdio-paranoia \ | libcdio_paranoia.so:sysutils/libcdio-paranoia \ | ||||
| libmodplug.so:audio/libmodplug \ | libmodplug.so:audio/libmodplug \ | ||||
| libvcdinfo.so:multimedia/vcdimager \ | libvcdinfo.so:multimedia/vcdimager \ | ||||
| libtheora.so:multimedia/libtheora \ | libtheora.so:multimedia/libtheora \ | ||||
| libmad.so:audio/libmad \ | libmad.so:audio/libmad \ | ||||
| libdca.so:multimedia/libdca \ | libdca.so:multimedia/libdca \ | ||||
| libavcodec.so:multimedia/ffmpeg \ | libavcodec.so:multimedia/ffmpeg \ | ||||
| libfaad.so:audio/faad \ | libfaad.so:audio/faad \ | ||||
| libvdpau.so:multimedia/libvdpau | libvdpau.so:multimedia/libvdpau \ | ||||
tobik: This looks strange to me. Every media player dlopen's libdvdcss but no other player has a block… | |||||
| .if !defined(PACKAGE_BUILDING) | libvpx.so:multimedia/libvpx \ | ||||
| # DVDCSS version hardcoded in src/input/input_dvd.c misc/cdda_server.c | libiso9660.so:sysutils/libcdio \ | ||||
| # and src/input/libdvdnav/dvd_input.c (dlopen'ed) | libogg.so:audio/libogg \ | ||||
Done Inline ActionsPlease remove libdvdcss here. When I said remove the block I meant all of it :). libdvdcss cannot be added to LIB_DEPENDS as it is currently marked as restricted. There is no package for it in the official repository which would also mean no package for libxine. This is also the reason why applications typically dlopen it instead of linking to it directly. tobik: Please remove libdvdcss here. When I said remove the block I meant all of it :). libdvdcss… | |||||
Done Inline ActionsIn a quick test build I got Error: /usr/local/lib/xine/plugins/2.7/xineplug_decode_spu.so is linked to /usr/local/lib/libdvdnav.so.4 from multimedia/libdvdnav but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libdvdnav.so:multimedia/libdvdnav This was outside of Poudriere, so it might have been picked up accidentally. I'd suggest just adding it, because it looks like libxine would use a bundled libdvdnav otherwise. From a Poudriere build log: checking for DVDNAV... no *** no usable version of libdvdnav found, using internal copy *** tobik: In a quick test build I got
```
Error: /usr/local/lib/xine/plugins/2.7/xineplug_decode_spu.so… | |||||
| LIB_DEPENDS+= libdvdcss.so.2:multimedia/libdvdcss | libdvdnav.so:multimedia/libdvdnav | ||||
| .endif | |||||
| USES= compiler cpe gmake iconv libtool:keepla \ | USES= compiler cpe gmake gnome iconv libtool:keepla jpeg \ | ||||
Done Inline Actionsmissing space after jpeg. mat: missing space after jpeg. | |||||
| localbase pathfix perl5 pkgconfig tar:xz | localbase pathfix perl5 pkgconfig tar:xz | ||||
| LLD_UNSAFE= yes | |||||
Done Inline ActionsThat comment is useless. mat: That comment is useless.
LLD_UNSAFE is only used on 12-CURRENT, so it is obvious.
You should… | |||||
| CPE_PRODUCT= xine-lib | CPE_PRODUCT= xine-lib | ||||
| CPE_VENDOR= xine | CPE_VENDOR= xine | ||||
| GNU_CONFIGURE= yes | GNU_CONFIGURE= yes | ||||
| USE_XORG= x11 xv xinerama xext sm ice | USE_XORG= x11 xcb xv xinerama xext sm ice | ||||
| USE_GL= gl glu | USE_GL= gl glu | ||||
| USE_PERL5= build | USE_PERL5= build | ||||
| USE_SDL= sdl | USE_SDL= sdl | ||||
| USE_LDCONFIG= yes | USE_LDCONFIG= yes | ||||
| CONFIGURE_ARGS= --with-w32-path=${LOCALBASE}/lib/win32 \ | CONFIGURE_ARGS= --enable-ipv6 \ | ||||
| --enable-ipv6 \ | |||||
| --with-external-libmad \ | --with-external-libmad \ | ||||
| --with-external-libdts \ | --with-external-libdts \ | ||||
| --with-libflac \ | --with-libflac \ | ||||
| --with-external-ffmpeg \ | --with-external-ffmpeg \ | ||||
| --with-external-libfaad \ | --with-external-libfaad \ | ||||
| --disable-real-codecs \ | --disable-real-codecs \ | ||||
| --disable-v4l \ | --disable-v4l \ | ||||
| --without-alsa \ | --without-alsa \ | ||||
| --disable-musepack \ | --disable-musepack | ||||
| --enable-dvb | |||||
Not Done Inline ActionsNo DVB support anymore? Or is it implied now? tobik: No DVB support anymore? Or is it implied now? | |||||
Not Done Inline ActionsIf enabled build fails and didn’t give much of error. Got to xine depends on ... found and stops ndowens_yahoo.com: If enabled build fails and didn’t give much of error. Got to xine depends on ... found and stops | |||||
Not Done Inline ActionsYou're very light on the details. I'm assuming you mean that configure fails with it enabled? If so have you looked at ${WRKSRC}/config.log to find out why? tobik: You're very light on the details. I'm assuming you mean that configure fails with it enabled? | |||||
Not Done Inline Actionsconfigure: error: DVB support requested, but DVB not found > Script "configure" failed unexpectedly.Please report the problem to ports@FreeBSD.org [maintainer] and attach the
ndowens_yahoo.com: configure: error: DVB support requested, but DVB not found
===> Script "configure" failed… | |||||
Not Done Inline ActionsThe only reason this happens is because files/patch-configure was deleted. Please bring it back and put back --enable-dvb (or make it an option). It might need to be rebased but it still largely applies. tobik: The only reason this happens is because `files/patch-configure` was deleted. Please bring it… | |||||
Done Inline ActionsThe last entry here shouln't end in a \. What happened to --disable-musepack? tobik: The last entry here shouln't end in a \. What happened to --disable-musepack? | |||||
Not Done Inline ActionsMust have been accidentally removed ndowens_yahoo.com: Must have been accidentally removed | |||||
| MAKE_ENV= V=1 | MAKE_ENV= V=1 | ||||
| LLD_UNSAFE= yes | MAKE_ARGS= pkgdatadir="${DATADIR}" \ | ||||
| datadir="${DATADIR}" \ | |||||
Done Inline ActionsUse ${DATADIR} instead of ${PREFIX}/share/${PORTNAME} tobik: Use `${DATADIR}` instead of `${PREFIX}/share/${PORTNAME}` | |||||
| libdir="${PREFIX}/lib" | |||||
Done Inline ActionsIs this still needed? tobik: Is this still needed? | |||||
| CFLAGS_i386= -fomit-frame-pointer | |||||
| DOCSDIR= ${PREFIX}/share/doc/xine-lib | DOCSDIR= ${PREFIX}/share/doc/xine-lib | ||||
| # Please sync with XINE_PLUGINSDIR in multimedia/xine | # Please sync with XINE_PLUGINSDIR in multimedia/xine | ||||
| # and multimedia/vdr-plugin-xineliboutput | # and multimedia/vdr-plugin-xineliboutput | ||||
| PLUGINSDIR= lib/xine/plugins/2.5 | PLUGINSDIR= lib/xine/plugins/2.7 | ||||
Not Done Inline ActionsSince this was bumped here, it needs to be changed in multimedia/xine and multimedia/vdr-plugin-xineliboutput too and should probably happen at the same time. tobik: Since this was bumped here, it needs to be changed in multimedia/xine and multimedia/vdr-plugin… | |||||
| PLIST_SUB= PLUGINSDIR="${PLUGINSDIR}" | PLIST_SUB= PLUGINSDIR="${PLUGINSDIR}" | ||||
| BROKEN_aarch64= Fails to configure: error: no acceptable as found in $PATH | OPTIONS_DEFINE= DOCS NLS CACA DVB DMX_IMAGE ESOUND IPV6 IMAGEMAGICK JACK \ | ||||
| GNOMEVFS2 PIXBUF PULSEAUDIO XVMC SMB SNDIO AALIB WAVPACK \ | |||||
Done Inline Actionslibxine has an sndio backend. Could you add an SNDIO option too? tobik: libxine has an sndio backend. Could you add an SNDIO option too? | |||||
| OPTIONS_DEFINE= NLS CACA ESOUND JACK GNOMEVFS2 PULSEAUDIO XVMC SMB AALIB \ | VAAPI LIBBLURAY | ||||
Done Inline ActionsEnable DVB by default as it was before. tobik: Enable DVB by default as it was before. | |||||
| IMAGEMAGICK PIXBUF WAVPACK VAAPI LIBBLURAY | # W32Codecs only build on i386 | ||||
| OPTIONS_DEFAULT=VAAPI | # Without option, there are plist issues | ||||
| OPTIONS_DEFINE_i386= W32CODECS | |||||
| OPTIONS_DEFAULT= DVB IMAGEMAGICK VAAPI | |||||
| OPTIONS_SUB= yes | OPTIONS_SUB= yes | ||||
| DMX_IMAGE_DESC= DMX image plugin | |||||
| DVB_DESC= Enable DVB plugin | |||||
| W32CODECS_DESC= Enable Win32 binary codecs | |||||
| NLS_USES= gettext | AALIB_LIB_DEPENDS= libaa.so:graphics/aalib | ||||
Done Inline ActionsThis should, and all other, should not depend on auto-detection. It should preferably be something like: AALIB_CONFIGURE_ENABLE= aalib aalibtest Use _WITH for --with/--without arguments. mat: This should, and all other, should not depend on auto-detection. It should preferably be… | |||||
| NLS_CONFIGURE_ENABLE= nls | AALIB_CONFIGURE_ENABLE= aalib aalibtest | ||||
| CACA_LIB_DEPENDS= libcaca.so:graphics/libcaca | CACA_LIB_DEPENDS= libcaca.so:graphics/libcaca | ||||
Done Inline ActionsThis was --disable-cacatest, are you sure this change is ok? mat: This was --disable-cacatest, are you sure this change is ok? | |||||
Not Done Inline ActionsSeems option doesn't exist. Removed ndowens_yahoo.com: Seems option doesn't exist. Removed | |||||
| CACA_CONFIGURE_OFF= --without-caca --disable-cacatest | CACA_CONFIGURE_WITH= caca | ||||
| DVB_CONFIGURE_ENABLE= dvb | |||||
Done Inline ActionsWhy this change to {BUILD,RUN}_DEPENDS? tobik: Why this change to `{BUILD,RUN}_DEPENDS`? | |||||
Done Inline ActionsWithout, build will fail when option is selected ndowens_yahoo.com: Without, build will fail when option is selected | |||||
| ESOUND_USE= GNOME=esound | ESOUND_USE= GNOME=esound | ||||
Not Done Inline ActionsLooks like this needs extra pkgs to build support; currently working on seeing if I can get a pkg built that will HOPEFULLY allow it to be built ndowens_yahoo.com: Looks like this needs extra pkgs to build support; currently working on seeing if I can get a… | |||||
Not Done Inline ActionsUpdate: The package I think it needs, seems to be impossible to port and project seems to be dead. IIRC last release was in 2006 or 07. I think it's best to remove option ndowens_yahoo.com: Update: The package I think it needs, seems to be impossible to port and project seems to be… | |||||
| ESOUND_CONFIGURE_OFF= --without-esound | ESOUND_CONFIGURE_WITH= esound | ||||
| GNOMEVFS2_USE= GNOME=glib20,gconf2,gnomevfs2 | |||||
Done Inline ActionsSame as ESOUND. tobik: Same as ESOUND. | |||||
| GNOMEVFS2_CONFIGURE_ENABLE= gnomevfs | |||||
| IMAGEMAGICK_CONFIGURE_WITH= imagemagick | |||||
| IMAGEMAGICK_LIB_DEPENDS= libMagickWand-6.so:graphics/ImageMagick | |||||
Done Inline ActionsThis is still wrong. Why does the previous way with ESOUND_USE= GNOME=esound not work? tobik: This is still wrong.
Why does the previous way with
```
ESOUND_USE= GNOME=esound
```
not work? | |||||
| IPV6_CONFIGURE_ENABLE= ipv6 | |||||
| JACK_LIB_DEPENDS= libjack.so:audio/jack | JACK_LIB_DEPENDS= libjack.so:audio/jack | ||||
Not Done Inline ActionsIs actually needed to build with support . Same with esound ndowens_yahoo.com: Is actually needed to build with support . Same with esound | |||||
| JACK_CONFIGURE_OFF= --without-jack | JACK_CONFIGURE_WITH= jack | ||||
| GNOMEVFS2_USE= GNOME=gnomevfs2 | LIBBLURAY_LIB_DEPENDS= libbluray.so:multimedia/libbluray | ||||
Done Inline ActionsGNOMEVFS2_USE= GNOME=glib20,gconf2,gnomevfs2 tobik: ```
GNOMEVFS2_USE= GNOME=glib20,gconf2,gnomevfs2
``` | |||||
| GNOMEVFS2_CONFIGURE_OFF=--disable-gnomevfs | LIBBLURAY_CONFIGURE_ENABLE= bluray | ||||
| NLS_USES= gettext | |||||
| NLS_CONFIGURE_ENABLE= nls | |||||
Done Inline ActionsThere is no _USE_GNOME options helper. PIXBUF_USE= GNOME=gdkpixbuf2,glib20 tobik: There is no _USE_GNOME options helper.
```
PIXBUF_USE= GNOME=gdkpixbuf2,glib20
``` | |||||
Done Inline ActionsMeant to remove that ndowens_yahoo.com: Meant to remove that | |||||
| PIXBUF_CONFIGURE_ENABLE= gdkpixbuf | |||||
| PIXBUF_USE= GNOME=gdkpixbuf2,glib20 | |||||
| PULSEAUDIO_LIB_DEPENDS= libpulse.so:audio/pulseaudio | PULSEAUDIO_LIB_DEPENDS= libpulse.so:audio/pulseaudio | ||||
| PULSEAUDIO_CONFIGURE_OFF=--without-pulseaudio | PULSEAUDIO_CONFIGURE_WITH= pulseaudio | ||||
| .if defined(WITH_NVIDIA304_GL) || exists(${LOCALBASE}/lib/libXvMCNVIDIA.so.1) | |||||
| XVMC_CONFIGURE_ON= --with-xvmc-lib=XvMCNVIDIA | |||||
| XVMC_LIB_DEPENDS= libXvMCNVIDIA.so:x11/nvidia-driver-304 | |||||
| .else | |||||
| XVMC_CONFIGURE_ON= --with-xvmc-lib=XvMCW | |||||
| XVMC_LIB_DEPENDS= libXvMC.so:x11/libXvMC | |||||
| .endif | |||||
| XVMC_CONFIGURE_OFF= --disable-xvmc | |||||
| SMB_USES= samba:lib | SMB_USES= samba:lib | ||||
| SMB_CONFIGURE_ENV= LIBSMBCLIENT_LIBS="-L${SAMBALIBS} -lsmbclient" \ | SMB_CONFIGURE_ENV= LIBSMBCLIENT_LIBS="-L${SAMBALIBS} -lsmbclient" \ | ||||
| LIBSMBCLIENT_CFLAGS="-I${SAMBAINCLUDES}" | LIBSMBCLIENT_CFLAGS="-I${SAMBAINCLUDES}" | ||||
| SMB_CONFIGURE_ENABLE= samba | SMB_CONFIGURE_ENABLE= samba | ||||
| AALIB_LIB_DEPENDS= libaa.so:graphics/aalib | SNDIO_CONFIGURE_ENABLE= sndio | ||||
| AALIB_CONFIGURE_OFF= --disable-aalib --disable-aalibtest | SNDIO_LIB_DEPENDS= libsndio.so:audio/sndio | ||||
| IMAGEMAGICK_LIB_DEPENDS= libMagickWand-6.so:graphics/ImageMagick | VAAPI_LIB_DEPENDS= libva.so:multimedia/libva | ||||
Not Done Inline ActionsThank you for adding it. LIB_DEPENDS implies that the library must be available at both build and run time, so SNDIO_BUILD_DEPENDS should not really be needed. tobik: Thank you for adding it.
`LIB_DEPENDS` implies that the library must be available at both… | |||||
| IMAGEMAGICK_CONFIGURE_OFF= --without-imagemagick | VAAPI_CONFIGURE_ENABLE= vaapi | ||||
| PIXBUF_USE= GNOME=gdkpixbuf2 | VIDIX_CONFIGURE_ENABLE= vidix | ||||
| PIXBUF_CONFIGURE_OFF= --disable-gdkpixbuf | W32CODECS_CONFIGURE_WITH= w32-path=${LOCALBASE}/lib/win32 | ||||
| WAVPACK_LIB_DEPENDS= libwavpack.so:audio/wavpack | WAVPACK_LIB_DEPENDS= libwavpack.so:audio/wavpack | ||||
| WAVPACK_CONFIGURE_WITH= wavpack | WAVPACK_CONFIGURE_WITH= wavpack | ||||
| VAAPI_LIB_DEPENDS= libva.so:multimedia/libva | |||||
| VAAPI_CONFIGURE_ON= --enable-vaapi | |||||
| LIBBLURAY_LIB_DEPENDS= libbluray.so:multimedia/libbluray | |||||
| LIBBLURAY_CONFIGURE_ENABLE= bluray | |||||
| .include <bsd.port.options.mk> | .if defined(WITH_NVIDIA304_GL) || exists(${LOCALBASE}/lib/libXvMCNVIDIA.so.1) | ||||
Done Inline ActionsNot wrong, but since you're touching almost the entire Makefile replace it with CFLAGS_i386= -fomit-frame-pointer tobik: Not wrong, but since you're touching almost the entire Makefile replace it with
```… | |||||
Not Done Inline ActionsI think .if ${PORT_OPTIONS:NIMAGEMAGICK} || ${PORT_OPTIONS:NPIXBUF}would be clearer here. tobik: I think
```
.if ${PORT_OPTIONS:NIMAGEMAGICK} || ${PORT_OPTIONS:NPIXBUF}
```
would be clearer… | |||||
Not Done Inline ActionsI mean .if ${PORT_OPTIONS:MIMAGEMAGICK} || ${PORT_OPTIONS:MPIXBUF}tobik: I mean
```
.if ${PORT_OPTIONS:MIMAGEMAGICK} || ${PORT_OPTIONS:MPIXBUF}
``` | |||||
Not Done Inline ActionsOh, you brought the .if back :-(. I think the earlier attempt with an W32DLL option was much nicer and I think was the right approach. tobik: Oh, you brought the `.if` back :-(. I think the earlier attempt with an W32DLL option was much… | |||||
Not Done Inline ActionsAh looking at the Makefile didn’t remember could do option_plist ndowens_yahoo.com: Ah looking at the Makefile didn’t remember could do option_plist | |||||
Not Done Inline ActionsYou cannot use options helpers after .include <bsd.port.options.mk>. Options have been processed at that point. Any options helper must always be before it or bsd.port.pre.mk. tobik: You cannot use options helpers after `.include <bsd.port.options.mk>`. Options have been… | |||||
| XVMC_CONFIGURE_WITH= xvmc-lib=XvMCNVIDIA | |||||
| .if ${ARCH} == "i386" | XVMC_LIB_DEPENDS= libXvMCNVIDIA.so:x11/nvidia-driver-304 | ||||
| CFLAGS+= -fomit-frame-pointer | |||||
| .endif | |||||
| .if ${CONFIGURE_ARGS:M*--without-imagemagick*} == "" || ${CONFIGURE_ARGS:M*-disable-gdkpixbuf*} == "" | |||||
| PLIST_SUB+= WITH_DMX_IMAGE="" | |||||
| .else | .else | ||||
| PLIST_SUB+= WITH_DMX_IMAGE="@comment " | XVMC_CONFIGURE_WITH= xvmc-lib=XvMCW | ||||
| XVMC_LIB_DEPENDS= libXvMC.so:x11/libXvMC | |||||
| .endif | .endif | ||||
| XVMC_CONFIGURE_ENABLE= xvmc | |||||
Done Inline ActionsI think it would be easier to create a DMX_IMAGE option and: IMAGEMAGICK_IMPLIES= DMX_IMAGE PIXBUF_IMPLIES= DMX_IMAGE mat: I think it would be easier to create a DMX_IMAGE option and:
```
IMAGEMAGICK_IMPLIES=… | |||||
Not Done Inline ActionsQuite frankly, I don't even understand what that is for. By looking at bsd.port.mk files seems I wouldn't need the plist_sub since i have options_sub=yes ndowens_yahoo.com: Quite frankly, I don't even understand what that is for. By looking at bsd.port.mk files seems… | |||||
Done Inline Actionsxineplug_dmx_image.so could previously be built with IMAGEMAGICK=off and PIBXUF=on or with IMAGEMAGICK=on and PIXBUF=off or with both on. The WITH_DMX_IMAGE thing was a way to encode this in the plist. But we can achieve the same thing with a DMX_IMAGE option as @mat suggested. The plist entry for xineplug_dmx_image.so also needs to make use of it again. tobik: `xineplug_dmx_image.so` could previously be built with IMAGEMAGICK=off and PIBXUF=on or with… | |||||
| .if ${ARCH} == "i386" | IMAGEMAGICK_IMPLIES= DMX_IMAGE | ||||
| PLIST_SUB+= WITH_VIDIX="" | PIXBUF_IMPLIES= DMX_IMAGE | ||||
Done Inline ActionsConvert this to an option while here. OPTIONS_DEFINE_i386= VIDIX OPTIONS_DEFAULT_i386= VIDIX VIDIX_DESC= Vidix (w32dll, qt) support # or a better description VIDIX_CONFIGURE_ENABLE= vidix tobik: Convert this to an option while here.
```
OPTIONS_DEFINE_i386= VIDIX… | |||||
Not Done Inline ActionsMaybe it's poudriere, but I can't get this to work on my i386 jail ndowens_yahoo.com: Maybe it's poudriere, but I can't get this to work on my i386 jail | |||||
| .else | |||||
| PLIST_SUB+= WITH_VIDIX="@comment " | |||||
| CONFIGURE_ARGS+= --disable-vidix | |||||
| .endif | |||||
| .include <bsd.port.pre.mk> | .include <bsd.port.pre.mk> | ||||
| post-patch: | post-patch: | ||||
| .if ${COMPILER_TYPE} == "clang" | .if ${COMPILER_TYPE} == "clang" | ||||
| @${REINPLACE_CMD} -e 's|-fno-rename-registers||' \ | @${REINPLACE_CMD} -e 's|-fno-rename-registers||' \ | ||||
| ${WRKSRC}/src/libw32dll/wine/Makefile.in | ${WRKSRC}/src/libw32dll/wine/Makefile.in | ||||
| .endif | .endif | ||||
| @${REINPLACE_CMD} -e 's|-ldl||' \ | @${REINPLACE_CMD} -e 's|-ldl||' \ | ||||
| ${WRKSRC}/src/video_out/Makefile.in | ${WRKSRC}/src/video_out/Makefile.in | ||||
| @${REINPLACE_CMD} -e "s|#define _ATOM QT_ATOM('', '', '', '')||" \ | @${REINPLACE_CMD} -e "s|#define _ATOM QT_ATOM('', '', '', '')||" \ | ||||
| ${WRKSRC}/src/demuxers/demux_qt.c | ${WRKSRC}/src/demuxers/demux_qt.c \ | ||||
| @${REINPLACE_CMD} -e \ | |||||
| 's|{libdir}/pkgconfig|{prefix}/libdata/pkgconfig|' \ | |||||
| ${WRKSRC}/configure | ${WRKSRC}/configure | ||||
Done Inline ActionsCould be dropped since the framework now moves things from lib/pkgconfig to libdata/pkgconfig automatically. tobik: Could be dropped since the framework now moves things from `lib/pkgconfig` to… | |||||
| # XXX older nvidia-driver versions don't support opengl 2.0 so this | |||||
| # plugin might not get built: | |||||
| post-install: | post-install: | ||||
| @if ! [ -e "${STAGEDIR}${PREFIX}/${PLUGINSDIR}/xineplug_vo_out_opengl2.so" ]; then \ | |||||
| ${REINPLACE_CMD} -e '/xineplug_vo_out_opengl2.so/d' \ | |||||
| ${TMPPLIST}; \ | |||||
| fi | |||||
| @${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/*.so | @${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/*.so | ||||
Done Inline ActionsI doubt this is still true with the NVIDIA drivers we have in the ports tree. tobik: I doubt this is still true with the NVIDIA drivers we have in the ports tree. | |||||
| @${STRIP_CMD} ${STAGEDIR}${PREFIX}/${PLUGINSDIR}/*.so | @${STRIP_CMD} ${STAGEDIR}${PREFIX}/${PLUGINSDIR}/*.so | ||||
| @${STRIP_CMD} ${STAGEDIR}${PREFIX}/${PLUGINSDIR}/post/*.so | @${STRIP_CMD} ${STAGEDIR}${PREFIX}/${PLUGINSDIR}/post/*.so | ||||
| .include <bsd.port.post.mk> | .include <bsd.port.post.mk> | ||||
This looks strange to me. Every media player dlopen's libdvdcss but no other player has a block like this. It also doesn't have any effect in package builders. I think this block should be removed.